Refactor to merge ViewController and PayloadTransport classes
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewcontroller-and-payloadtransport
smithki
deleted the
chore/refactor-viewcontroller-and-payloadtransport
branch
smithki
added a commit
that referenced
this pull request
Sep 2, 2021
* (feat): Added 'web3-core' package v1.5.2 to import the new AbstractProvider Type * (feat): fix #83 * First step to refactoring 'PayloadTransport' into 'ViewController' * Fix remaining tests * Update 'peerDependencies' for @magic-sdk/commons * Fix clean script Co-authored-by: Adenekan Wonderful <[email protected]>
smithki
added a commit
that referenced
this pull request
Sep 10, 2021
* Re-factor scripts for building, development, linting, and cleaning to TypeScript * Remove remnants of old test runner (ava) * Re-factor scripts for unit testing to TypeScript * Small cleanups * Refactor to merge `ViewController` and `PayloadTransport` classes (#203) * (feat): Added 'web3-core' package v1.5.2 to import the new AbstractProvider Type * (feat): fix #83 * First step to refactoring 'PayloadTransport' into 'ViewController' * Fix remaining tests * Update 'peerDependencies' for @magic-sdk/commons * Fix clean script Co-authored-by: Adenekan Wonderful <[email protected]> * Make script code more DRY * Update TypeScript & make scripts more DRY * Fix typo and add 'printSeparator' script utility * Fix 'inject-env.ts' script following re-organization of code * Remove outdated / unused dependencies from root PackageJSON * Progress towards integrating microbundle * Update build scripts to bundle all packages via microbundle * Remove unnecessary console statement * Run pre-commit hooks against all packages * Add more memory for tasks spawned via 'wsrun' * Raise the resource class in CI * Try to fix ENOMEM errors in CI by limiting concurrency * Replace 'p-limit' dependency with prior version (new version is ESM-only) * Better caching in CircleCI * Update test script to work with Yarn 2 * Fix tests related to ViewController refactor * Reduce the CircleCI resource class back to medium * Fix tests related to ViewController refactor Co-authored-by: Adenekan Wonderful <[email protected]>
smithki
added a commit
that referenced
this pull request
Sep 14, 2021
* Re-factor build scripts to TypeScript (#202) * Re-factor scripts for building, development, linting, and cleaning to TypeScript * Remove remnants of old test runner (ava) * Re-factor scripts for unit testing to TypeScript * Small cleanups * Refactor to merge `ViewController` and `PayloadTransport` classes (#203) * (feat): Added 'web3-core' package v1.5.2 to import the new AbstractProvider Type * (feat): fix #83 * First step to refactoring 'PayloadTransport' into 'ViewController' * Fix remaining tests * Update 'peerDependencies' for @magic-sdk/commons * Fix clean script Co-authored-by: Adenekan Wonderful <[email protected]> * Make script code more DRY * Update TypeScript & make scripts more DRY * Fix typo and add 'printSeparator' script utility * Fix 'inject-env.ts' script following re-organization of code * Remove outdated / unused dependencies from root PackageJSON * Progress towards integrating microbundle * Update build scripts to bundle all packages via microbundle * Remove unnecessary console statement * Run pre-commit hooks against all packages * Add more memory for tasks spawned via 'wsrun' * Raise the resource class in CI * Try to fix ENOMEM errors in CI by limiting concurrency * Replace 'p-limit' dependency with prior version (new version is ESM-only) * Better caching in CircleCI * Update test script to work with Yarn 2 * Fix tests related to ViewController refactor * Reduce the CircleCI resource class back to medium * Fix tests related to ViewController refactor Co-authored-by: Adenekan Wonderful <[email protected]> * Fix ENV variable interpolations * Force publish * Remove temporary change (#205) * Add '--force-publish' flag to 'lerna version' command * Apply forcePublish to 'auto' * Log environment in one place during build * Trigger publish on 'magic-sdk' and '@magic-sdk/react-native' * Remove comments used to trigger prerelease * Fix SemVer issues * Ignore 'semver' wrapper from test coverage * Target 'web' Co-authored-by: Adenekan Wonderful <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Merges the functionality of
ViewControllerandPayloadTransportinto one class.