Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Update type signature of RpcProviderModule to implement Web3's AbstractProvider #201

Merged
merged 3 commits into from
Sep 2, 2021
Merged

[Feat]: Update type signature of RpcProviderModule to implement Web3's AbstractProvider #201

merged 3 commits into from
Sep 2, 2021

Conversation

adenekan41
Copy link
Contributor

📦 Pull Request

✅ Fixed Issues

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@adenekan41 adenekan41 added the minor Increment the minor version when merged label Sep 1, 2021
@adenekan41 adenekan41 self-assigned this Sep 1, 2021
@adenekan41 adenekan41 marked this pull request as draft September 1, 2021 20:06
@smithki smithki added skip-release Preserve the current version when merged and removed skip-release Preserve the current version when merged labels Sep 2, 2021
@smithki smithki marked this pull request as ready for review September 2, 2021 20:46
@adenekan41 adenekan41 merged commit d64e27e into master Sep 2, 2021
@adenekan41 adenekan41 deleted the feat/implement-abstract-provider branch September 2, 2021 20:53
@smithki smithki added the released This issue/pull request has been released. label Sep 2, 2021
@smithki smithki added the prerelease This change is available in a prerelease. label Sep 17, 2021
@smithki
Copy link
Contributor

smithki commented Sep 17, 2021

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@magiclabs magiclabs deleted a comment from shortcut-integration bot Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smithki smithki smithki approved these changes

Assignees

@adenekan41 adenekan41

Labels
minor Increment the minor version when merged prerelease This change is available in a prerelease. released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update type signature of RpcProviderModule to implement Web3's AbstractProvider
2 participants
@adenekan41 @smithki