Iframe accessibility improvements: Add title
attribute and auto-focus when UI is showing
#158
+68
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
This change includes two small accessibility improvements:
<iframe>
now has atitle
attribute ("Secure Modal"
).title
attribute andaria-label
will be configurable.<iframe>
is given focus immediately, this reduces the friction for keyboard & screen-reader users to interact with Magic's UI.🚨 Test instructions
PKG=magic-sdk yarn test
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.