Support expo 38 #111

Ethella · 2020-06-28T20:18:40Z

Add buffer and process to dependencies

📦 Pull Request

Support react-native-webview": "9.4.0" which has been used in Expo 38 SDK

🗜 Versioning

(Check one!)

Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

✅ Fixed Issues

Fixes Support Expo SDK 38 #110

🚨 Test instructions

Run it on Simulator and real Devices

⚠️ Update `CHANGELOG.md`

I have updated the Upcoming Changes section of CHANGELOG.md with context related to this Pull Request.

* Add buffer and process to dependencies

smithki

Just a nit comment, otherwise approved!

packages/react-native/src/index.ts

smithki · 2020-07-01T17:27:23Z

Looks like some type errors failed the tests as well.

smithki · 2020-07-02T23:50:37Z

packages/react-native/src/index.ts

@@ -12,7 +11,7 @@ import { SDKBaseReactNative } from './react-native-sdk-base';

 // We expect `global.process` to be a Node Process,
 // so we replace it here.
-global.process = processPolyfill || {};
+if (global.process) global.process = { ...global.process, ...require('process') };


probably want an else case here

# Conflicts: # packages/react-native/package.json

# Conflicts: # packages/react-native/package.json # yarn.lock

* spread polyfill into global.process

Ethella · 2020-07-07T23:45:03Z

Punting this PR from merging, as the Expo team has just shared with their implementation. It may involve some changes afterward.

# Conflicts: # packages/react-native/CHANGELOG.md

smithki · 2020-07-18T15:21:55Z

Looks like some tests are failing due to the addition of a process.removeListener call in the RN environment.

DanielRamosAcosta · 2020-08-03T08:44:52Z

Hello @smithki! Is there anything I could help? Fixing the tests? I'm starting a new project with Expo 38 but the webview doens't even show up.

smithki · 2020-08-03T17:27:27Z

~~cc @Ethella, would you take a look at the failing RN tests. Seems to be missing process.addListener and process.removeListener.~~

I'd like to give open-source contributors the first shot at fixing these broken tests, actually :)

smithki · 2020-08-03T19:52:04Z

Hello @smithki! Is there anything I could help? Fixing the tests? I'm starting a new project with Expo 38 but the webview doens't even show up.

@DanielRamosAcosta You're absolutely welcome to pull the branch and investigate the broken tests, it's only affecting React Native, but if you're able to get them in a working condition, I'd be happy to merge the PR!

Ethella · 2020-08-04T04:40:28Z

Hello @smithki! Is there anything I could help? Fixing the tests? I'm starting a new project with Expo 38 but the webview doens't even show up.

Hi @DanielRamosAcosta, if you encounter an issue that the webview doesn't show. You could give 36 or 37 a try.

DanielRamosAcosta · 2020-08-04T07:42:31Z

Hello @smithki! Is there anything I could help? Fixing the tests? I'm starting a new project with Expo 38 but the webview doens't even show up.

Hi @DanielRamosAcosta, if you encounter an issue that the webview doesn't show. You could try 36 or 37 a try.

Ok, I'm going to try SDK 37 to see if I can reproduce

Ethella · 2020-08-04T07:59:14Z

Hello @smithki! Is there anything I could help? Fixing the tests? I'm starting a new project with Expo 38 but the webview doens't even show up.

Hi @DanielRamosAcosta, if you encounter an issue that the webview doesn't show. You could try 36 or 37 a try.

Ok, I'm going to try SDK 37 to see if I can reproduce

Feel free to file an issue in this repo if you can reproduce it.

DanielRamosAcosta · 2020-08-04T08:55:52Z

I've been trying to downgrade to SDK 37 but there are lot of things that depends on 38 in my current app (fonts, libraries...) I'll give it another try with an isolated app this evening.

DanielRamosAcosta · 2020-08-07T19:25:06Z

Didn't have time in the end to test with SDK 37, but the new version works with SDK 38 as a charm! Great work! 👏

smithki · 2020-10-22T05:08:03Z

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

Ethella added 3 commits June 26, 2020 16:18

* Remove upper version limit for peerDependencies

bb401cd

* Add buffer and process to dependencies

* Remove upper limit of webview dependency

a251d19

* Update CHANGELOG.md

3f71426

Ethella requested a review from smithki June 28, 2020 20:18

Ethella self-assigned this Jun 28, 2020

smithki previously approved these changes Jun 29, 2020

View reviewed changes

packages/react-native/src/index.ts Outdated Show resolved Hide resolved

* Use object spread to replace process

8b3c312

Ethella dismissed smithki’s stale review via 8b3c312 July 2, 2020 23:38

smithki suggested changes Jul 2, 2020

View reviewed changes

Ethella added 3 commits July 2, 2020 16:59

Merge remote-tracking branch 'origin/master' into Support-Expo-38

5320fe8

# Conflicts: # packages/react-native/package.json

Merge remote-tracking branch 'origin/master' into Support-Expo-38

7061000

# Conflicts: # packages/react-native/package.json # yarn.lock

* Add else case for global.process

322e71f

* spread polyfill into global.process

Ethella added 2 commits July 8, 2020 14:27

use typof to check global.process

4a23f5f

Merge remote-tracking branch 'origin/master' into Support-Expo-38

eccafce

# Conflicts: # packages/react-native/CHANGELOG.md

Ethella added 3 commits July 29, 2020 16:02

Merge remote-tracking branch 'origin/master' into Support-Expo-38

691ac4f

Merge remote-tracking branch 'origin/master' into Support-Expo-38

9210beb

* Add post install script

0e846a6

smithki previously approved these changes Jul 31, 2020

View reviewed changes

Fix tests

4486acc

Ethella dismissed smithki’s stale review via 4486acc August 4, 2020 04:08

smithki previously approved these changes Aug 4, 2020

View reviewed changes

Fix tests

e7f0583

Ethella dismissed smithki’s stale review via e7f0583 August 4, 2020 07:33

Add type/lodash

1f00c6e

Add elevation for Android

79266db

Ethella requested a review from smithki August 4, 2020 18:22

smithki approved these changes Aug 4, 2020

View reviewed changes

Ethella merged commit e511668 into master Aug 4, 2020

Ethella deleted the Support-Expo-38 branch August 4, 2020 19:52

smithki added the released This issue/pull request has been released. label Oct 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support expo 38 #111

Support expo 38 #111

Ethella commented Jun 28, 2020

smithki left a comment

smithki commented Jul 1, 2020

smithki Jul 2, 2020

Ethella commented Jul 7, 2020

smithki commented Jul 18, 2020

DanielRamosAcosta commented Aug 3, 2020 •

edited

Loading

smithki commented Aug 3, 2020 •

edited

Loading

smithki commented Aug 3, 2020 •

edited

Loading

Ethella commented Aug 4, 2020 •

edited

Loading

DanielRamosAcosta commented Aug 4, 2020

Ethella commented Aug 4, 2020

DanielRamosAcosta commented Aug 4, 2020

DanielRamosAcosta commented Aug 7, 2020

smithki commented Oct 22, 2020

Support expo 38 #111

Support expo 38 #111

Conversation

Ethella commented Jun 28, 2020

📦 Pull Request

🗜 Versioning

✅ Fixed Issues

🚨 Test instructions

⚠️ Update CHANGELOG.md

smithki left a comment

Choose a reason for hiding this comment

smithki commented Jul 1, 2020

smithki Jul 2, 2020

Choose a reason for hiding this comment

Ethella commented Jul 7, 2020

smithki commented Jul 18, 2020

DanielRamosAcosta commented Aug 3, 2020 • edited Loading

smithki commented Aug 3, 2020 • edited Loading

smithki commented Aug 3, 2020 • edited Loading

Ethella commented Aug 4, 2020 • edited Loading

DanielRamosAcosta commented Aug 4, 2020

Ethella commented Aug 4, 2020

DanielRamosAcosta commented Aug 4, 2020

DanielRamosAcosta commented Aug 7, 2020

smithki commented Oct 22, 2020

⚠️ Update `CHANGELOG.md`

DanielRamosAcosta commented Aug 3, 2020 •

edited

Loading

smithki commented Aug 3, 2020 •

edited

Loading

smithki commented Aug 3, 2020 •

edited

Loading

Ethella commented Aug 4, 2020 •

edited

Loading