Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Extension warnings and deprecation notices #109

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Add Extension warnings and deprecation notices #109

merged 5 commits into from
Jun 25, 2020

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Jun 25, 2020

📦 Pull Request

  • Add MagicExtensionWarning
  • Add SDKWarningCode.DeprecationNotice along with standard methods for communicating deprecations
  • Add encodeJSON and decodeJSON, mark encodeQueryParameters and decodeQueryParameters for deprecation.

🗜 Versioning

(Check one!)

  • Patch: Bug Fix?
  • Minor: New Feature?
  • Major: Breaking Change?

⚠️ Update CHANGELOG.md

  • I have updated the Upcoming Changes section of CHANGELOG.md with context related to this Pull Request.

@smithki smithki changed the title Smithki add extension warnings and deprecation notices Add Extension warnings and deprecation notices Jun 25, 2020
Dizigen
Dizigen previously approved these changes Jun 25, 2020
View reviewed changes
@smithki smithki merged commit d75104f into master Jun 25, 2020
@smithki smithki deleted the smithki_add_extension_warnings_and_deprecation_notices branch June 25, 2020 21:12
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dizigen Dizigen Dizigen left review comments

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smithki @Dizigen