Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain globals need polyfilling for React Native #62

Closed
3 tasks done
smithki opened this issue Apr 23, 2020 · 1 comment · Fixed by #63
Closed
3 tasks done

Certain globals need polyfilling for React Native #62

smithki opened this issue Apr 23, 2020 · 1 comment · Fixed by #63
Assignees
@smithki
Labels
🐛 Bug Report 📱 React Native React-native related released This issue/pull request has been released.
Milestone
04/20 - 04/27: Qu...

Comments

@smithki
Copy link
Contributor

smithki commented Apr 23, 2020

✅ Prerequisites

  • Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • Are you running the latest SDK version?
  • Are you reporting to the correct repository (magic-sdk)?

🐛 Description

atob, btoa, and process is not defined in React Native.

🧩 Steps to Reproduce

  1. Set up React Native Project
  2. Import/instantiate Magic
  3. Broken 😢

🤔 Expected behavior

React Native should work!

😮 Actual behavior

Undefined globals if the environment is not correctly polyfilled.

💻 Code Sample

None.

🌎 Environment

Software Version(s)
magic-sdk
Browser
yarn
Operating System
@smithki smithki self-assigned this Apr 23, 2020
@smithki smithki mentioned this issue Apr 23, 2020
Merged
4 tasks
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

🚀 Issue was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smithki smithki

Labels
🐛 Bug Report 📱 React Native React-native related released This issue/pull request has been released.
Projects
None yet
Milestone
04/20 - 04/27: Quarantine continues 😷
Development

Successfully merging a pull request may close this issue.

Polyfill certain globals for React Native magiclabs/magic-js
1 participant
@smithki