Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React Native #35

Closed
smithki opened this issue Apr 9, 2020 · 5 comments · Fixed by #37
Closed

Support React Native #35

smithki opened this issue Apr 9, 2020 · 5 comments · Fixed by #37
Assignees
@smithki
Labels
📱 React Native React-native related released This issue/pull request has been released.
Milestone
04/20 - 04/27: Qu...

Comments

@smithki
Copy link
Contributor

smithki commented Apr 9, 2020

Jerry has built a foundation of work that we can follow here to implement React Native support: https://github.com/fortmatic/fortmatic-js/tree/react-native-2.1

I will be prioritizing this after Web3 support ships in #28
@smithki smithki self-assigned this Apr 9, 2020
@Ethella
Copy link
Member

Ethella commented Apr 11, 2020

Thx for tackling it. It really relieved my stress.

Just adding here. There's something I would love to tackle before we officially release

    "whatwg-url": "^8.0.0"  
    "react-native-webview": "^8.1.2",

By installing it in our SDK, it will reduce overheads for developers. RN is super dependency sensitive and lacking of backward compatibilities. Any version update might result in broken projects. So it might be a good idea to manage it by ourselves.

  • react-native-webview has a version restriction, Version 9 would introduce another bug.
  • URL is not supported in RN, so we need to import { URL } form 'whatwg-url'. But the package itself is 300kb after bundling, so it would be nice if it can be built only to RN.

@Ethella
Copy link
Member

Ethella commented Apr 11, 2020 •
edited

Also, you may test ether.js to see what are the dependencies required as it's our supported library for magic. Hopefully, it should work with web3.js environment dependencies.

@smithki
Copy link
Contributor Author

smithki commented Apr 12, 2020

Also, you may test ether.js to see what are the dependencies required as it's our supported library for magic. Hopefully, it should work with web3.js environment dependencies.

Sean has been creating Web3/Ethers examples over the past few days. As far as i can tell, there have been no incompatibilities between our rpcProvider and Ethers 🚀

@Ethella
Copy link
Member

Ethella commented Apr 12, 2020 via email

@smithki smithki mentioned this issue Apr 17, 2020
Closed
@Ethella Ethella added the 📱 React Native React-native related label Apr 17, 2020
@smithki smithki mentioned this issue Apr 18, 2020
Merged
4 tasks
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

🚀 Issue was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smithki smithki

Labels
📱 React Native React-native related released This issue/pull request has been released.
Projects
None yet
Milestone
04/20 - 04/27: Quarantine continues 😷
Development

Successfully merging a pull request may close this issue.

Support React Native magiclabs/magic-js
3 participants
@FYJen @smithki @Ethella