Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base url and bump version #8

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Update base url and bump version #8

merged 5 commits into from
Apr 20, 2020

Conversation

FYJen
Copy link
Contributor

@FYJen FYJen commented Apr 18, 2020

This PR:

  1. updates the base url
  2. bumps the version
  3. fixes version reader

@FYJen FYJen requested review from d9chen and Jmjin April 18, 2020 00:13
@FYJen FYJen self-assigned this Apr 18, 2020
d9chen
d9chen previously approved these changes Apr 20, 2020
View reviewed changes
Copy link

@d9chen d9chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm fix n ship!

magic_admin/config.py Show resolved Hide resolved
@FYJen FYJen merged commit dc22df0 into master Apr 20, 2020
@FYJen FYJen mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d9chen d9chen d9chen left review comments

@Jmjin Jmjin Awaiting requested review from Jmjin

Assignees

@FYJen FYJen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FYJen @d9chen