Add granularity for DID Token Errors #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
The
DIDTokenError
is too vague so we split this up intoDIDTokenExpired
,DIDTokenMalformed
, andDIDTokenInvalid
.DIDTokenMalformed
: raised when DID token cannot be decoded or if required fields are missingDIDTokenExpired
: raised when current time > DID Token expiration timeDIDTokenInvalid
: raised when DID token can be decoded but does not pass validation (missing values, signature mismatch, etc.)🗜 Versioning
(Check one!)
✅ Fixed Issues
🚨 Test instructions
Tests pass with
make test
.CHANGELOG.md
Upcoming Changes
section ofCHANGELOG.md
with context related to this Pull Request.