Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providers are not shown in Authentication Popup on standard pages #71

Closed
cundd opened this issue May 6, 2021 · 2 comments
Closed

Providers are not shown in Authentication Popup on standard pages #71

cundd opened this issue May 6, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@cundd
Copy link
Contributor

cundd commented May 6, 2021

The list of providers is not rendered in the Authentication Popup on CMS or Catalog pages.

Desktop:

  • Device: MacBook Pro M1
  • OS: macOS 11.3
  • Browser Chrome
  • Version 90.0

Additional context
Guest checkout is disabled
@cundd
Copy link
Contributor Author

cundd commented May 6, 2021

The jsLayout XML to add children to the authenticationPopup is not always added to the layout. This could be done in the default.xml

cundd added a commit to iresults/customerTwoFactorAuth that referenced this issue May 6, 2021
@cundd
Fix providers are not shown in Authentication Popup on standard pages m…
0c83b22 
…agetarian#71
@atishgoswami atishgoswami added the bug Something isn't working label May 6, 2021
cundd added a commit to iresults/customerTwoFactorAuth that referenced this issue May 6, 2021
@cundd
Fix providers are not shown in Authentication Popup on standard pages m…
ca20b6d 
…agetarian#71
atishgoswami added a commit that referenced this issue Jun 2, 2021
@atishgoswami
Merge pull request #72 from iresults/feature/enhance-authentication-p…
2789775 
…opup-support

Fix providers are not shown in Authentication Popup on pages #71
@atishgoswami
Copy link
Contributor

Thank you much for reporting the issue and providing the PRs for the fixes

@cundd you were own first external contributor to this project 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cundd @atishgoswami