Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST and GraphQL functional test workflows #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gowrizrh
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Fixes: #97

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@gowrizrh gowrizrh requested a review from a team as a code owner September 16, 2023 04:01

steps:
- uses: actions/checkout@v3
- name: Set PHP Version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reworked to use the new setup-magento and cache-magento commands.

tools: composer:v${{ matrix.composer }}
coverage: none

- run: composer create-project --repository-url="${{ inputs.magento_repository }}" "${{ matrix.magento }}" ${{ inputs.magento_directory }} --no-install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reworked to use the new setup-magento and cache-magento commands.

@damienwebdev
Copy link
Member

damienwebdev commented Sep 19, 2023

@gowrizrh see my example here: #140

I think we should tackle this before bringing in new workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Support API and GraphQL tests
2 participants