fix: handle undefined reference caused by no tags on commerce-data-export
#165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly build is currently failing:
This is caused by https://github.com/mage-os/mirror-commerce-data-export not having any tags. This PR makes some changes to cover that:
ref
(default branch here). If there is noref
in the package config, fall back toHEAD
. (*I am concerned about what side effects that might have -- but since all modules to date have had tags other than this one, I don't think any other code paths will trigger this.)validateRefIsSecure
orvalidateBranchIsSecure
is called with a falsey value (undefined), throw error rather than attempt string comparisons.