Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy] Allow configuring AZURE_HOST for authentication. #5166

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

wangxiaoyou1993
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 commented Jun 6, 2024

Description

Configurable environment variables

  • AZURE_HOST
  • MICROSOFT_GRAPH_API_HOST

Possible Azure hosts: https://github.com/Azure/azure-sdk-for-net/blob/06dd672e59d9bd6068e8ef282cb94ae17e6f75be/sdk/identity/Azure.Identity/src/AzureAuthorityHosts.cs#L13-L16

AzurePublicCloudHostUrl = "https://login.microsoftonline.com/";
AzureChinaHostUrl = "https://login.chinacloudapi.cn/";
AzureGermanyHostUrl = "https://login.microsoftonline.de/";
AzureGovernmentHostUrl = "https://login.microsoftonline.us/";

Possible Microsoft Graph API endpoints:
https://learn.microsoft.com/en-us/graph/deployments#microsoft-graph-and-graph-explorer-service-root-endpoints

How Has This Been Tested?

  • Build test docker image to test with Azure Gov

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the enhancement Polish or UX improvements label Jun 6, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit 1d29894 into master Jun 7, 2024
11 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/azure-host branch June 7, 2024 07:29
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Jun 20, 2024
6 tasks
wangxiaoyou1993 added a commit that referenced this pull request Jun 20, 2024
# Description
<!-- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
-->
Bump version to 0.9.72

### 🎉 Exciting New Features
* [td] Canvas V2 by @tommydangerous in
#5193
* Support custom python sink in Streaming pipeline by @lgarcia11 in
#5174
### 🐛 Bug Fixes
* [xy] Fix delete/update workspace. by @wangxiaoyou1993 in
#5146
* [td] Fix Dockerfile to install faster fifo from source by
@tommydangerous in #5152
* [xy] Fix import and add user to verify_project. by @wangxiaoyou1993 in
#5151
* [xy] Fix auto_clean_name param. by @wangxiaoyou1993 in
#5161
* [xy] Bump the version of dbt-sqlserver to 1.7.4 by @wangxiaoyou1993 in
#5162
* [xy] Fix api trigger token comparison. by @wangxiaoyou1993 in
#5167
* [td] Update Snowflake timeout to network_timeout by @tommydangerous in
#5173
* [xy] Fix executor type when not specified. by @wangxiaoyou1993 in
#5175
* [td] Disable playright, never finishes no windows server 3.10 by
@tommydangerous in #5190
* [xy] Fix global data product in single project. by @wangxiaoyou1993 in
#5205
* [td] Revert Next _app back before breaking change by @tommydangerous
in #5207
* [td] Put back Monaco Editor files by @tommydangerous in
#5208
### 💅 Enhancements & Polish
* [xy] Update pypi github action by @wangxiaoyou1993 in
#5145
* [td] Magic Kernel using server-sent events to execute code from client
by @tommydangerous in #5131
* [td] Standalone Monaco editor by @tommydangerous in
#5160
* [td] Integrate LSP by @tommydangerous in
#5163
* [xy] Allow configuring custom owner credentials. by @wangxiaoyou1993
in #5165
* [xy] Allow configuring AZURE_HOST for authentication. by
@wangxiaoyou1993 in #5166
* [xy] Upgrade polars package version by @wangxiaoyou1993 in
#5176
* [td] Grid layout v2 by @tommydangerous in
#5168
* [td] System browser by @tommydangerous in
#5177
* [xy] Speed up Pipeline get and list. by @wangxiaoyou1993 in
#5187
* [xy] Speed up autocomplete endpoint with cache. by @wangxiaoyou1993 in
#5188
* [td] Browser items API by @tommydangerous in
#5189
* [td] Fix styles and integrate real files by @tommydangerous in
#5184
* [td] Fix app manager and app loading by @tommydangerous in
#5191
* [td] IDE CRUD operations by @tommydangerous in
#5192
* [xy] Custom kubernetes job prefix by @wangxiaoyou1993 in
#5195
* [xy] Try using xlarge in circleci. by @wangxiaoyou1993 in
#5206
### Other Changes
* Added repo_path to block kwargs and os.environ, improves multi-project
feature by @hugabora in #5144
* [td] DLS v2 by @tommydangerous in
#5147
* Updated Variable Name for Cohesion by @Ayumi08 in
#5148
* Remove leading whitespace from Telegram notification message (Issue
#4877) by @Ayumi08 in #5153
* [TC] Update releases.mdx by @thomaschung408 in
#5156
* docs: fix markdown formatting by @ValentinOtt in
#5059
* [tc] Update community-examples.mdx by @thomaschung408 in
#5172
* [td] System browser context menu by @tommydangerous in
#5178


# How Has This Been Tested?
<!-- Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
-->

- [x] Common tests locally


# Checklist
- [x] The PR is tagged with proper labels (bug, enhancement, feature,
documentation)
- [x] I have performed a self-review of my own code
- [ ] I have added unit tests that prove my fix is effective or that my
feature works
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation

cc:
<!-- Optionally mention someone to let them know about this pull request
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Polish or UX improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant