Event detection for ic stride #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stride update _event_detection_mixin.py to check consistency of "ic" stride
AKuederle
reviewed
Mar 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 91.55% 90.27% -1.29%
==========================================
Files 85 85
Lines 4797 4884 +87
==========================================
+ Hits 4392 4409 +17
- Misses 405 475 +70 ☔ View full report in Codecov by Sentry. |
|
@AKuederle Could you please review? |
AKuederle
requested changes
Mar 22, 2024
| @@ -53,7 +55,8 @@ class HerzerEventDetection(_EventDetectionMixin, BaseEventDetection): | |||
| By default, all events ("ic", "tc", "min_vel") are detected. | |||
| If `min_vel` is not detected, the `min_vel_event_list_` output will not be available. | |||
| If "ic" is not detected, the `pre_ic` will also not be available in the output. | |||
|
|
|||
| input_stride_type | |||
There was a problem hiding this comment.
Can you add a note here, that only segmented is supported by this algo
| @@ -153,6 +157,7 @@ class RamppEventDetection(_EventDetectionMixin, BaseEventDetection): | |||
|
|
|||
| ic_search_region_ms: Tuple[float, float] | |||
There was a problem hiding this comment.
What happens to this value, if the stride-type is ic? This seems to be ignored and you use other hardcoded thresholds.
| @@ -38,6 +40,8 @@ class RamppEventDetection(_EventDetectionMixin, BaseEventDetection): | |||
| By default, all events ("ic", "tc", "min_vel") are detected. | |||
| If `min_vel` is not detected, the `min_vel_event_list_` output will not be available. | |||
| If "ic" is not detected, the `pre_ic` will also not be available in the output. | |||
| input_stride_type | |||
There was a problem hiding this comment.
We need to document what happens in case of IC strides as input. Probably something ot put in the Notes section
gaitmap_mad/gaitmap_mad/event_detection/_rampp_event_detection.py
Outdated
Show resolved
Hide resolved
gaitmap_mad/gaitmap_mad/event_detection/_rampp_event_detection.py
Outdated
Show resolved
Hide resolved
…irst part of stance] change detect_tc to return nan if no negative values were found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the event detection algorithm to work on "ic" stride that start with initial contact