Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mkcert for creating a proper SSL certificates for tests #1143

Closed
macbre opened this issue May 3, 2022 · 0 comments · Fixed by #1168
Closed

Use mkcert for creating a proper SSL certificates for tests #1143

macbre opened this issue May 3, 2022 · 0 comments · Fixed by #1168
Assignees
@macbre
Labels
internals

Comments

@macbre
Copy link
Owner

macbre commented May 3, 2022

No more ignore-ssl-errors flag used.
@macbre macbre self-assigned this May 3, 2022
macbre added a commit that referenced this issue Jun 13, 2022
@macbre
CI: install and set up mkcert (#1143)
d27370d
@macbre macbre mentioned this issue Jun 13, 2022
Merged
5 tasks
macbre added a commit that referenced this issue Jun 14, 2022
@macbre
Use mkcert to set up trusted development certificates (#1168)
73b4f4f 
* Update test/ssl-certificate/generate.sh and update the tests README on how to set up mkcert

* CI: install and set up mkcert (#1143)

* Fix a typo

* CI: remove ignore-ssl-errors flags

* mkcert: make it work with puppeteer (see FiloSottile/mkcert#219)

* jest: decrease thresholds as we no longer test ignore-ssl-errors flag

* Container CI: run just a CLI script

Instead of the entire tests suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macbre macbre

Labels
internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use mkcert to set up trusted development certificates macbre/phantomas
1 participant
@macbre