Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new ngrx logo #143

Merged
merged 2 commits into from
May 29, 2024
Merged

feat: new ngrx logo #143

merged 2 commits into from
May 29, 2024

Conversation

jdegand
Copy link
Contributor

@jdegand jdegand commented May 26, 2024

  • Renamed the old ngrx logo and added the slightly different new design

@maartentibau
Copy link
Owner

@jdegand thx for your PR!

I'm wondering if we should not add some extra context in de metadata.json file for this?

Because of the new logo of Angular introduces with v17 .. I would maybe rename the old ngrx logo to ngrx-legacy.
What are your thoughs on this @fmalcher ?

@maartentibau maartentibau self-assigned this May 27, 2024
@fmalcher
Copy link
Collaborator

Same thought, actually 🙂 I'd rather keep older versions as some kind of archive.

@jdegand
Copy link
Contributor Author

jdegand commented May 27, 2024

I mirrored the way it was done with angular-universal-old.

@maartentibau maartentibau merged commit a6de054 into maartentibau:master May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants