Use modern Lisp features and software ADC #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VESC 6.05 introduced new LispBM features including the curly brackets
Changelog states "Removed array types other than byte arrays." which made the array-create argument obsolete.
- Lowered default throttle high to 150 (before it was 167) to avoid people running on the edge of the throttle range and now getting the full power of the scooter. This should be changed to your throttle values, but it's a good starting point. - Redefined the default secret mode values to be more useful for high power scooters. - High motor temp will now show up on the display - Locking the scooter will also disable the secret mode now
This script is not tested. DO NOT USE. It might not even run.
g30_dash.lisp confirmed to be working!
added missing { } (progn)
This issue was discussed in vedderb/bldc#655 > If the ADC app is disabled it will not run any set-current, set-rpm etc functions and therefore it stays at this value (and I am not sure if there is any timeout applied, I do not think so...)
|
Any updates on ADC flavor? |
On some ESCs this leads to the button being unresponsive during standstill.
This reverts commit 215846c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the following changes for VESC 6.05:
software-adcvariable from 1 to 0.Please review and merge the changes.