Clang fixes #8
Merged
Clang fixes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cupsFreeJobs and job_state check were inside the for loop. Therefore when the job was found and 'break' issued, the loop would exit and cupsFreeJob and the job_state check would never get called.
URL is later assigned from cupsServer(), which returns const char*.
I'm guessing that it only functioned due to how gcc compiled it. When compiled with clang, renders library unusable due to every call raising "The printer or destination doesn't exist!"
|
By the way - I've released the rest api I've developed using cups at: https://github.com/nathanstitt/restful-printing It's still very green, but is seing light production use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few bugs I've encountered when running on osx and using a clang compiled Ruby. The most surprising one was the missing return statement, I'm have no idea how/why gcc allowed that.
I've made several other changes as well: nathanstitt/cups@m0wfo:master...master and will be submitting pull requests for them separately.
As always - I'll be glad to rework if you'd like something done differently.
Thanks again!