Add title attr_accessor on Jobs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title is how print jobs are listed as in the print queue. This allows setting it to something useful for identifying jobs in case they need to be paused/canceled
|
Cool, looks good- thanks a lot for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title is how print jobs are listed as in the print queue. This allows setting it
to something useful for identifying jobs in case they need to be
paused/canceled
I'm writing a thin REST api service on top of cups and using your library to submit and list the status of jobs. The only problem I've ran into was that all the jobs appeared in the queue as "rCups". This should fix that.
Let me know if you'd like it reworked in some way, I'd be happy to do so.