Fix Yosemite build #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From CUPS 1.6, the visibility of parts of the IPP data structures controlled are by the preprocessor symbol IPP_PRIVATE_STRUCTURES. Visibility is enabled specifically for Mac OS X 10.8 and 10.9 but not for Mac OS X 10.10 in CUPS. This update forces the required visibility.
|
+1 Do get this merged soon. |
|
@miccheng thanks for this, will check this out later this evening (GMT) |
|
I just verified this works for me on Yosemite w/Ruby 2.0 & 2.1.3 |
|
@miccheng will do a release now |
|
@miccheng I have no time to fix / comprehensively verify this, and I'd like to move it all to the ruby FFI if I get time, but your fix is in 0.1.10- Thanks very much for the input :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From CUPS 1.6, the visibility of parts of the IPP data structures controlled are by the preprocessor symbol IPP_PRIVATE_STRUCTURES.
Visibility is enabled specifically for Mac OS X 10.8 and 10.9 but not for Mac OS X 10.10 in CUPS. This update forces the required visibility.