Skip to content

Commit

Permalink
Rollup merge of rust-lang#88202 - azdavis:master, r=jyn514
Browse files Browse the repository at this point in the history
Add an example for deriving PartialOrd on enums

For some reason, I always forget which variants are smaller and which
are larger when you derive PartialOrd on an enum. And the wording in the
current docs is not entirely clear to me.

So, I often end up making a small enum, deriving PartialOrd on it, and
then writing a `#[test]` with an assert that the top one is smaller than
the bottom one (or the other way around) to figure out which way the
deriving goes.

So then I figured, it would be great if the standard library docs just
had that example, so if I keep forgetting, at least I can figure it out
quickly by looking at std's docs.
  • Loading branch information
m-ou-se committed Sep 3, 2021
2 parents fbdff7f + 003a636 commit cb2be32
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions library/core/src/cmp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,18 @@ impl<T: Clone> Clone for Reverse<T> {
/// This trait can be used with `#[derive]`. When `derive`d on structs, it will produce a
/// [lexicographic](https://en.wikipedia.org/wiki/Lexicographic_order) ordering based on the top-to-bottom declaration order of the struct's members.
/// When `derive`d on enums, variants are ordered by their top-to-bottom discriminant order.
/// This means variants at the top are less than variants at the bottom.
/// Here's an example:
///
/// ```
/// #[derive(PartialEq, PartialOrd)]
/// enum Size {
/// Small,
/// Large,
/// }
///
/// assert!(Size::Small < Size::Large);
/// ```
///
/// ## Lexicographical comparison
///
Expand Down

0 comments on commit cb2be32

Please sign in to comment.