Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some ICE connectivity issues #1641

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix some ICE connectivity issues #1641

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ea945ff
Fix some ICE connectivity issues
jcague Oct 5, 2020
47e78b1
Fix lint
jcague Oct 5, 2020
9a546fd
Fix build
jcague Oct 6, 2020
5dc0964
Test with nicer branch
jcague Oct 6, 2020
def22dc
Merge branch 'master' of github.com:lynckia/licode into fix/wrong_ice…
jcague Oct 29, 2020
3507fd1
Merge branch 'master' of github.com:lynckia/licode into fix/wrong_ice…
jcague Nov 4, 2020
c17582d
Enable ICE Lite as a config param
jcague Nov 4, 2020
4bf6585
Add more stuff to test
jcague Nov 4, 2020
d1930ab
Fix lint
jcague Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix lint
  • Loading branch information
@jcague
jcague committed Nov 4, 2020
commit d1930ab6aeb01877b822f0d5fe010fd949027211
6 changes: 4 additions & 2 deletions erizo_controller/erizoJS/models/SessionDescription.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ class SessionDescription {
}

processSdp() {
const connDescription = new ConnectionDescription(Helpers.getMediaConfiguration(this.mediaConfiguration));
const connDescription =
new ConnectionDescription(Helpers.getMediaConfiguration(this.mediaConfiguration));
const sdp = this.sdp;
let audio;
let video;
Expand Down Expand Up @@ -304,7 +305,8 @@ class SessionDescription {
const candidates = media.getCandidates();
candidates.forEach((candidate) => {
const candidateString = candidateToString(candidate);
connDescription.addCandidate(media.getType(), candidate.getFoundation(), candidate.getComponentId(),
connDescription.addCandidate(media.getType(), candidate.getFoundation(),
candidate.getComponentId(),
candidate.getTransport(), candidate.getPriority(), candidate.getAddress(),
candidate.getPort(), candidate.getType(), candidate.getRelAddr(), candidate.getRelPort(),
candidateString);
Expand Down