lxd-to-incus: Add support for LXD 5.21 #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a trickier one as LXD 5.21 has added new DB tables and so requires a DB downgrade to the 5.20 schema prior to being able to move the data over to Incus. Signed-off-by: Stéphane Graber <[email protected]>
|
Should we prompt for confirmation if we're going to drop tables? |
|
@adamcstephens the data is moved away from those tables back to the original ones (it's basically running the schema migration steps in reverse) so that's fine to do. We also always make a full DB backup as part of running the migration. |
|
Great, thanks. Supporting 5.21 will be nice since it's an LTS and gives a hopefully gives a long timeline to migrate. :) |
13 tasks
freeekanayaka
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a trickier one as LXD 5.21 has added new DB tables and so requires a DB downgrade to the 5.20 schema prior to being able to move the data over to Incus.