-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage bucket backup #365
Conversation
07b814e
to
9acf4c9
Compare
@stgraber I'd love to get some early feedback on the "Storage Bucket Export" implementation as I tackle the import feature. |
Given that Incus is in charge of the keys to begin with and currently all keys allow for downloads, I don't think we need to provide that flag, Incus will just pick up a key from the list of keys and use that to fetch the data. |
624a565
to
bb02a1d
Compare
4329eee
to
a1e3ffe
Compare
@stgraber I customized the test suite to run only on the |
dd5ff2f
to
a16957a
Compare
Looks good. There are a couple of minor commit re-shuffle that I want to do on top of this but I'll do that myself and then merge, thanks! |
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
Signed-off-by: Fabian Mettler <[email protected]>
a16957a
to
50f73d4
Compare
This pull request add backup support for storage buckets from #241.
Description
Export
CLI
Archive
The export command creates a tarball from the defined bucket, which is structured as follows:
backup.yml
: contains the bucket metadata and keysbucket
: This folder contains the actual dataAPI
This includes the following new endpoints (see RESTful API for details):
GET /1.0/storage-pools/<pool>/buckets/<bucket>/backups
POST /1.0/storage-pools/<pool>/buckets/<bucket>/backups
GET /1.0/storage-pools/<pool>/buckets/<bucket>/backups/<name>
POST /1.0/storage-pools/<pool>/buckets/<bucket>/backups/<name>
DELETE /1.0/storage-pools/<pool>/buckets/<bucket>/backups/<name>
GET /1.0/storage-pools/<pool>/buckets/<bucket>/backups/<name>/export
Export
CLI
$ incus storage bucket import default backup.tar.gz bucket0 Backup exported successfully!
Design decisions
What's been changed
storage bucket export
andstorage bucket import
has been added to the command line interface (CLI).