Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dates for some feeds #1174

Closed
jfbauer432 opened this issue Nov 18, 2022 · 4 comments
Closed

Missing dates for some feeds #1174

jfbauer432 opened this issue Nov 18, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@jfbauer432
Copy link

I found some feeds that don't display any date in the Item List (headlines). I manually downloaded the feed data with wget and there are both updated and published fields for each entry. The "Date" heading is visible and clicking on it to change the sort does not have any affect of the order of the items. I have only seen this on feeds from one site, everything else is ok.

Example feed that does not display date in Item List.
https://forum.freecadweb.org/app.php/feed/forum/3

@jfbauer432
Copy link
Author

OS: Ubuntu 22.10
Liferea's Help->About says liferea 1.13.8
however Ubuntu dpkg -l liferea shows the version as 1.13.9-1

@jfbauer432
Copy link
Author

Got more info on this. I noticed that sometimes when doing a query of the above URL I got date/times with timezone offset and sometimes without. I eventually figured out I would get the dates with timezone when logged in, and without when logged out. I can also confirm that the times when there is not timezone offset if really UTC. So it might be an easy workaround.

@lwindolf
Copy link
Owner

Reproduced effect with entries in the feed without login. Entries look like this

	<entry>
	<author><name><![CDATA[drmacro]]></name></author>
	<updated>2022-12-14T22:02:55</updated>

	<published>2022-12-14T22:02:55</published>
	<id>http:https://forum.freecadweb.org:80/viewtopic.php?t=74450&amp;
	[...]
        </entry>

The date is correct ISO8601 so Liferea should parse it. The problem seems the implicit UTC timezone and us calling g_date_time_new_from_iso8601 (date, NULL) with NULL as default timezone. When passing g_time_zone_new_utc() instead the parsing works.

Needs to be fixed.

@lwindolf lwindolf added the bug label Dec 14, 2022
@lwindolf lwindolf self-assigned this Dec 15, 2022
@lwindolf lwindolf added this to the 1.14-RC3 milestone Dec 15, 2022
@lwindolf
Copy link
Owner

Test added for this. Solution implemented as described above.

Feed has now the proper timestamps. Please retest!

lwindolf added a commit that referenced this issue Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants