Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure option --enable-lvmlockd-idm broken by commit on 9Jul2021 #98

Closed
TProhofsky opened this issue Dec 8, 2022 · 1 comment
Closed

Configure option --enable-lvmlockd-idm broken by commit on 9Jul2021 #98

TProhofsky opened this issue Dec 8, 2022 · 1 comment

Comments

@TProhofsky
Copy link

The commit on 9 July 2021 removed the declaration of BUILD_LOCKDIDM required for using the --enable-lvmlockd-idm configure option. See https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3a92d633a5a23377aa0d5d4ed5a01db8ca14cf69

Please add it back in.

Thanks.
@zkabelac
Copy link

Thanks for noticing - the issue has been caused by missing AC_SUBST in configure.ac (fixed by this commit: https://listman.redhat.com/archives/lvm-devel/2023-February/024608.html )
Please retest with latest git HEAD with refreshed configure file as well - assuming it should be working now again.

jollaitbot pushed a commit to sailfishos-mirror/lvm2 that referenced this issue Feb 13, 2023
configure.ac: fix support for LOCKDIDM
b6efa82 
Commit 7a8b7b4 introducing lockidm
support missed to use AC_SUBST() for a variable and provide it only
in prebuilt configure, so with the next autoreconf this variable
was lost and IDM support was no longer compiled.

Fixes: lvmteam/lvm2#98
Reported-by: Tom Prohofsky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zkabelac @TProhofsky