-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
69-dm-lvm.rules conflicts with 63-md-raid-arrays.rules #94
Comments
I've removed the SYSTEMD_READY variable setting in 69-dm-lvm.rules - the way we do LVM autoactivation changed some time ago and we don't actually need to handle SYSTMED_READY anymore in our udev rules. Thanks for the report. https://sourceware.org/git/?p=lvm2.git;a=commit;h=e7c8a825061d57efaffad80667873fa8d68d31ab |
jollaitbot
pushed a commit
to sailfishos-mirror/lvm2
that referenced
this issue
Feb 1, 2023
Since 67722b3, we have a new mechanism to run the autoactivation from udev. With this change, we also replaced the way the LVM autoactivation service is instantiatiated - instead of setting the SYSTEM_WANTS udev variable (which systemd read and then instantiated the service), we're now directly instantiating the transient 'lvm-activate-<vgname>' service by calling systemd-run. As such, we don't need to bother with setting the SYSTEMD_READY variable for foreign devices anymore (in this case, MD and loop devices on top of which there's a PV). Before, we set the SYSTEMD_READY variable to make sure that the SYSTEMD_WANTS is applied correctly - the service instantiation was edge-triggered by flipping the SYSTEMD_READY from 0 to 1 and at the same time having the SYSTEMD_WANTS variable set to the service name to instantiate. We're using systemd-run now so this condition does not apply anymore. Also, it was not completely correct to set SYSTEMD_READY for foreign devices because there might be cases where this could cause issues, see also lvmteam/lvm2#94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
madm provides a 63-md-raid-arrays.rules (listed below) which is supposed to start mdmonitor service. However the service is not started, because 69-dm-lvm.rules resets SYSTEMD_READY flag.
Thanks
The text was updated successfully, but these errors were encountered: