Added dai_type to NNArchive #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moratom
approved these changes
Nov 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 92.33% 92.52% +0.19%
==========================================
Files 79 79
Lines 4161 4227 +66
==========================================
+ Hits 3842 3911 +69
+ Misses 319 316 -3 ☔ View full report in Codecov by Sentry. |
kozlov721
approved these changes
Nov 5, 2024
| deprecated="Deprecated, use `dai_type` instead.", | ||
| description="If True input to the model is interleaved (NHWC) else planar (NCHW).", | ||
| ) | ||
| dai_type: str = Field( |
There was a problem hiding this comment.
We should probably validate the value
There was a problem hiding this comment.
+1 on validating this str value. Maybe have a list of all the possible data types from DAI and ensure the given value exists there?
ptoupas
reviewed
Nov 6, 2024
luxonis_ml/nn_archive/config_building_blocks/base_models/input.py
Outdated
Show resolved
Hide resolved
ptoupas
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
config_versionis a string in format "x.y" where x and y are integerssubtypeis a string and not an Enumreverse_input_channelsandinterleaved_to_planarto match their real meaningdai_typeto the archive which is what DAI will read to automatically setup the pipeline