Skip to content

Commit

Permalink
Minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
marigostra committed Dec 31, 2022
1 parent acc4691 commit c083273
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 24 deletions.
5 changes: 1 addition & 4 deletions src/main/java/org/luwrain/app/mail/Extension.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ public final class Extension extends EmptyExtension
return new ExtensionObject[]{
new SimpleShortcut("mail", App.class),
new Shortcut() {
@Override public String getExtObjName()
{
return "message";
}
@Override public String getExtObjName() { return "message"; }
@Override public Application[] prepareApp(String[] args)
{
if (args.length == 0)
Expand Down
12 changes: 3 additions & 9 deletions src/main/java/org/luwrain/app/mail/Hooks.java
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,15 @@ List<SummaryItem> organizeSummary(MailMessage[] messages)
return items;
}

boolean makeReply(MailMessage message)
void makeReply(MailMessage message)
{
/*
NullCheck.notNull(message, "message");
final Object[] args = new Object[]{new MessageHookObject(message)};
try {
return new ChainOfResponsibilityHook(luwrain).run(REPLY_HOOK_NAME, args);
chainOfResponsibility(luwrain, REPLY, new Object[]{new MessageObj(message)});
}
catch(RuntimeException e)
{
Log.error(LOG_COMPONENT, "unable to run the " + REPLY_HOOK_NAME + ":" + e.getClass().getName() + ":" + e.getMessage());
return false;
luwrain.crash(e);
}
*/
return false;
}

Map<String, MailAccount> server(String mailAddr)
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/org/luwrain/app/mail/MainLayout.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@

final class MainLayout extends LayoutBase implements TreeListArea.LeafClickHandler<MailFolder>, ClickHandler<SummaryItem>
{
static private final InputEvent
HOT_KEY_REPLY = new InputEvent('r', EnumSet.of(InputEvent.Modifiers.ALT));

final App app;
final TreeListArea<MailFolder> foldersArea;
final ListArea<SummaryItem> summaryArea;
Expand Down Expand Up @@ -91,6 +94,7 @@ final class MainLayout extends LayoutBase implements TreeListArea.LeafClickHandl
action("new-folder", app.getStrings().actionNewFolder(), new InputEvent(InputEvent.Special.INSERT), MainLayout.this::actNewFolder),
fetchIncomingBkg),
summaryArea, actions(
action("reply", app.getStrings().actionReply(), HOT_KEY_REPLY, this::actSummaryReply),
fetchIncomingBkg
),
messageArea, actions(
Expand Down Expand Up @@ -200,7 +204,8 @@ private boolean actSummaryReply()
final SummaryItem item = summaryArea.selected();
if (item == null || item.message == null)
return false;
return app.getHooks().makeReply(item.message);
app.getHooks().makeReply(item.message);
return true;
}

boolean saveAttachment(String fileName)
Expand Down
12 changes: 7 additions & 5 deletions src/main/java/org/luwrain/app/mail/Strings.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,18 @@ public interface Strings
String appName();

String foldersAreaName();

String actionNewFolder();
String newFolderNamePopupName();
String newFolderNamePopupPrefix();

String actionRemoveFolder();
String removeFolderPopupName();
String removeFolderPopupText();
String actionFetchIncomingBkg();

String summaryAreaName();
String actionReply();
String actionReplyAll();


String messageAreaAttachment();
String messageAreaCc();
String messageAreaContentType();
Expand All @@ -43,8 +45,8 @@ public interface Strings
String messageAreaName();
String messageAreaSubject();
String messageAreaTo();
String summaryAreaName();
String actionFetchIncomingBkg();



String wizardIntro();
String wizardContinue();
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/luwrain/app/message/App.java
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public App()

public App(Message message)
{
super(Strings.NAME, Strings.class);
super(Strings.NAME, Strings.class, "luwrain.message");
this.message = message != null?message:new Message();
}

Expand Down Expand Up @@ -98,7 +98,7 @@ private void send(MailAccount account, MailMessage message) throws PimException
message.setFrom(getFromLine(account));
if (message.getFrom().trim().isEmpty())
throw new RuntimeException("No sender address");//FIXME:
message.setExtInfo(mailStoring.getAccounts().getUniRef(account));
//FIXME: message.setExtInfo(mailStoring.getAccounts().getUniRef(account));
fillMessageData(message);
/*
final MailFolder folder = mailStoring.getFolders().findFirstByProperty("defaultOutgoing", "true");
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/org/luwrain/app/message/MainLayout.java
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ final class MainLayout extends LayoutBase
params.context = getControlContext();
params.name = app.getStrings().appName();
params.text = text.toArray(new String[text.size()]);
params.to = app.message.getTo() != null?app.message.getTo().trim():"";
params.subject = app.message.getSubject() != null?app.message.getSubject().trim():"";
if (app.message.getAttachments() != null)
params.attachments = app.message.getAttachments().toArray(new String[app.message.getAttachments().size()]);
this.messageArea = new MessageArea(params){
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,24 @@ RemoveFolderPopupText = Вы действительно хотите удали




SummaryAreaName = Сообщения
ActionDeleteMessage = Удалить сообщение
ActionForward = Переслать
ActionReply = Ответить
ActionReplyAll = Ответить всем
ActionForward = Переслать


MessageAreaName = Сообщение
MessageAreaAttachment = Прикрепление:
MessageAreaContentType = Тип данных:
MessageAreaCc = Копия:
MessageAreaDate = Время отправления:
MessageAreaFrom = От:
MessageAreaName = Сообщение

MessageAreaSubject = Тема:
MessageAreaTo = Кому:
SummaryAreaName = Сообщения


WizardIntro = Необходимо произвести подключение к учётной записи вашей электронной почты. Укажите ваш адрес электронной почты в поле ниже и нажмите кнопку "Продолжить".
WizardContinue = Продолжить
Expand Down

0 comments on commit c083273

Please sign in to comment.