Skip to content

Commit

Permalink
LibWeb: Implement EventTarget.dispatchEvent
Browse files Browse the repository at this point in the history
Used by Web Platform Tests to test events
  • Loading branch information
Lubrsi authored and linusg committed May 4, 2021
1 parent 7f6baf8 commit 2cc6b91
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Userland/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,8 @@ static bool is_wrappable_type(const IDL::Type& type)
return true;
if (type.name.ends_with("Element"))
return true;
if (type.name.ends_with("Event"))
return true;
if (type.name == "ImageData")
return true;
return false;
Expand Down
15 changes: 15 additions & 0 deletions Userland/Libraries/LibWeb/DOM/EventTarget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/

#include <LibWeb/Bindings/ScriptExecutionContext.h>
#include <LibWeb/DOM/Event.h>
#include <LibWeb/DOM/EventListener.h>
#include <LibWeb/DOM/EventTarget.h>

Expand Down Expand Up @@ -53,4 +54,18 @@ void EventTarget::remove_from_event_listener_list(NonnullRefPtr<EventListener> l
});
}

// https://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent
ExceptionOr<bool> EventTarget::dispatch_event_binding(NonnullRefPtr<Event> event)
{
if (event->dispatched())
return DOM::InvalidStateError::create("The event is already being dispatched.");

if (!event->initialized())
return DOM::InvalidStateError::create("Cannot dispatch an uninitialized event.");

event->set_is_trusted(false);

return dispatch_event(event);
}

}
3 changes: 3 additions & 0 deletions Userland/Libraries/LibWeb/DOM/EventTarget.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <AK/Noncopyable.h>
#include <AK/Vector.h>
#include <LibJS/Forward.h>
#include <LibWeb/DOM/ExceptionOr.h>
#include <LibWeb/Forward.h>

namespace Web::DOM {
Expand All @@ -31,6 +32,8 @@ class EventTarget {
void remove_from_event_listener_list(NonnullRefPtr<EventListener>);

virtual bool dispatch_event(NonnullRefPtr<Event>) = 0;
ExceptionOr<bool> dispatch_event_binding(NonnullRefPtr<Event>);

virtual JS::Object* create_wrapper(JS::GlobalObject&) = 0;
Bindings::ScriptExecutionContext* script_execution_context() { return m_script_execution_context; }

Expand Down
3 changes: 3 additions & 0 deletions Userland/Libraries/LibWeb/DOM/EventTarget.idl
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
interface EventTarget {

// FIXME: Both of these should take in options
undefined addEventListener(DOMString type, EventListener? callback);
undefined removeEventListener(DOMString type, EventListener? callback);

[ImplementedAs=dispatch_event_binding] boolean dispatchEvent(Event event);

};

0 comments on commit 2cc6b91

Please sign in to comment.