Skip to content

Commit

Permalink
Kernel+LibC: Implement getsockname() syscall.
Browse files Browse the repository at this point in the history
  • Loading branch information
awesomekling committed May 19, 2019
1 parent 0eb788d commit 212a263
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 0 deletions.
25 changes: 25 additions & 0 deletions Kernel/Process.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2217,6 +2217,31 @@ ssize_t Process::sys$recvfrom(const Syscall::SC_recvfrom_params* params)
return socket.recvfrom(*descriptor, buffer, buffer_length, flags, addr, addr_length);
}

int Process::sys$getsockname(int sockfd, sockaddr* addr, socklen_t* addrlen)
{
if (!validate_read_typed(addrlen))
return -EFAULT;

if (*addrlen <= 0)
return -EINVAL;

if (!validate_write(addr, *addrlen))
return -EFAULT;

auto* descriptor = file_descriptor(sockfd);
if (!descriptor)
return -EBADF;

if (!descriptor->is_socket())
return -ENOTSOCK;

auto& socket = *descriptor->socket();
if (!socket.get_address(addr, addrlen))
return -EINVAL; // FIXME: Should this be another error? I'm not sure.

return 0;
}

int Process::sys$getsockopt(const Syscall::SC_getsockopt_params* params)
{
if (!validate_read_typed(params))
Expand Down
1 change: 1 addition & 0 deletions Kernel/Process.h
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ class Process : public InlineLinkedListNode<Process>, public Weakable<Process> {
ssize_t sys$recvfrom(const Syscall::SC_recvfrom_params*);
int sys$getsockopt(const Syscall::SC_getsockopt_params*);
int sys$setsockopt(const Syscall::SC_setsockopt_params*);
int sys$getsockname(int sockfd, sockaddr* addr, socklen_t* addrlen);
int sys$restore_signal_mask(dword mask);
int sys$create_thread(int(*)(void*), void*);
void sys$exit_thread(int code);
Expand Down
2 changes: 2 additions & 0 deletions Kernel/Syscall.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ static dword handle(RegisterDump& regs, dword function, dword arg1, dword arg2,
return current->process().sys$mknod((const char*)arg1, (mode_t)arg2, (dev_t)arg3);
case Syscall::SC_writev:
return current->process().sys$writev((int)arg1, (const struct iovec*)arg2, (int)arg3);
case Syscall::SC_getsockname:
return current->process().sys$getsockname((int)arg1, (sockaddr*)arg2, (socklen_t*)arg3);
default:
kprintf("<%u> int0x82: Unknown function %u requested {%x, %x, %x}\n", current->process().pid(), function, arg1, arg2, arg3);
break;
Expand Down
1 change: 1 addition & 0 deletions Kernel/Syscall.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@
__ENUMERATE_SYSCALL(mknod) \
__ENUMERATE_SYSCALL(writev) \
__ENUMERATE_SYSCALL(beep) \
__ENUMERATE_SYSCALL(getsockname) \


namespace Syscall {
Expand Down
6 changes: 6 additions & 0 deletions LibC/sys/socket.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,10 @@ int setsockopt(int sockfd, int level, int option, const void* value, socklen_t v
__RETURN_WITH_ERRNO(rc, rc, -1);
}

int getsockname(int sockfd, struct sockaddr* addr, socklen_t* addrlen)
{
int rc = syscall(SC_getsockname, sockfd, addr, addrlen);
__RETURN_WITH_ERRNO(rc, rc, -1);
}

}
1 change: 1 addition & 0 deletions LibC/sys/socket.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ ssize_t recv(int sockfd, void*, size_t, int flags);
ssize_t recvfrom(int sockfd, void*, size_t, int flags, struct sockaddr*, socklen_t*);
int getsockopt(int sockfd, int level, int option, void*, socklen_t*);
int setsockopt(int sockfd, int level, int option, const void*, socklen_t);
int getsockname(int sockfd, struct sockaddr*, socklen_t*);

__END_DECLS

0 comments on commit 212a263

Please sign in to comment.