forked from SerenityOS/serenity
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Travis: Run script that checks for forbidden symbols in LibC
check-symbols.sh fails the build if undefined __cx_guard_* symbols are found in LibC. This will help us catch port breakage sooner.
- Loading branch information
1 parent
542f665
commit 1c20e68
Showing
2 changed files
with
22 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
#!/bin/sh | ||
|
||
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P) | ||
cd "$script_path/.." | ||
|
||
# The __cxa_guard_* calls are generated for (non trivial) initialzation of local static objects. | ||
# These symbols are OK to use within serenity code, but they are problematic in LibC because their | ||
# existence breaks ports (the implementation of these symbols resides in libstdc++.a which we do not link against in ports). | ||
# To eliminate the need for these symbols, avoid doing non-trivial construction of local statics in LibC. | ||
|
||
FORBIDDEN_SYMBOLS="__cxa_guard_acquire __cxa_guard_release" | ||
LIBC_PATH="Build/Libraries/LibC/libc.a" | ||
for forbidden_symbol in $FORBIDDEN_SYMBOLS; do | ||
# check if symbol is undefined | ||
nm $LIBC_PATH | grep "U $forbidden_symbol" | ||
if [ $? -eq 0 ]; then | ||
echo "Forbidden undefined symbol in LibC: $forbidden_symbol" | ||
echo "See comment in Meta/check-symbols.sh for more info" | ||
exit 1 | ||
fi | ||
done |