Kernel: Use default constructors/destructors

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
luteresa · Mar 17, 2022 · 190cf15 · 190cf15
1 parent 68f75ab
commit 190cf15
Show file tree

Hide file tree

Showing 79 changed files with 102 additions and 309 deletions.
diff --git a/Kernel/Arch/aarch64/ScopedCritical.cpp b/Kernel/Arch/aarch64/ScopedCritical.cpp
@@ -10,13 +10,8 @@
 
 namespace Kernel {
 
-ScopedCritical::ScopedCritical()
-{
-}
-
-ScopedCritical::~ScopedCritical()
-{
-}
+ScopedCritical::ScopedCritical() = default;
+ScopedCritical::~ScopedCritical() = default;
 
 ScopedCritical::ScopedCritical(ScopedCritical&& /*from*/)
 {

diff --git a/Kernel/Arch/aarch64/SmapDisabler.cpp b/Kernel/Arch/aarch64/SmapDisabler.cpp
@@ -13,8 +13,6 @@ SmapDisabler::SmapDisabler()
 {
 }
 
-SmapDisabler::~SmapDisabler()
-{
-}
+SmapDisabler::~SmapDisabler() = default;
 
 }
diff --git a/Kernel/Bus/USB/SysFSUSB.cpp b/Kernel/Bus/USB/SysFSUSB.cpp
@@ -20,9 +20,7 @@ SysFSUSBDeviceInformation::SysFSUSBDeviceInformation(NonnullOwnPtr<KString> devi
 {
 }
 
-SysFSUSBDeviceInformation::~SysFSUSBDeviceInformation()
-{
-}
+SysFSUSBDeviceInformation::~SysFSUSBDeviceInformation() = default;
 
 ErrorOr<void> SysFSUSBDeviceInformation::try_generate(KBufferBuilder& builder)
 {

diff --git a/Kernel/Bus/USB/UHCI/UHCIController.cpp b/Kernel/Bus/USB/UHCI/UHCIController.cpp
@@ -89,9 +89,7 @@ UNMAP_AFTER_INIT UHCIController::UHCIController(PCI::DeviceIdentifier const& pci
 {
 }
 
-UNMAP_AFTER_INIT UHCIController::~UHCIController()
-{
-}
+UNMAP_AFTER_INIT UHCIController::~UHCIController() = default;
 
 ErrorOr<void> UHCIController::reset()
 {

diff --git a/Kernel/Bus/USB/USBDevice.cpp b/Kernel/Bus/USB/USBDevice.cpp
@@ -51,9 +51,7 @@ Device::Device(Device const& device, NonnullOwnPtr<Pipe> default_pipe)
 {
 }
 
-Device::~Device()
-{
-}
+Device::~Device() = default;
 
 ErrorOr<void> Device::enumerate_device()
 {

diff --git a/Kernel/Bus/USB/USBTransfer.cpp b/Kernel/Bus/USB/USBTransfer.cpp
@@ -24,9 +24,7 @@ Transfer::Transfer(Pipe& pipe, u16 len, NonnullOwnPtr<Memory::Region> data_buffe
 {
 }
 
-Transfer::~Transfer()
-{
-}
+Transfer::~Transfer() = default;
 
 void Transfer::set_setup_packet(const USBRequestData& request)
 {

diff --git a/Kernel/Bus/VirtIO/Queue.cpp b/Kernel/Bus/VirtIO/Queue.cpp
@@ -44,9 +44,7 @@ Queue::Queue(NonnullOwnPtr<Memory::Region> queue_region, u16 queue_size, u16 not
  enable_interrupts();
 }
 
-Queue::~Queue()
-{
-}
+Queue::~Queue() = default;
 
 void Queue::enable_interrupts()
 {

diff --git a/Kernel/Devices/Audio/AC97.cpp b/Kernel/Devices/Audio/AC97.cpp
@@ -36,9 +36,7 @@ UNMAP_AFTER_INIT AC97::AC97(PCI::DeviceIdentifier const& pci_device_identifier)
 {
 }
 
-UNMAP_AFTER_INIT AC97::~AC97()
-{
-}
+UNMAP_AFTER_INIT AC97::~AC97() = default;
 
 bool AC97::handle_irq(RegisterState const&)
 {

diff --git a/Kernel/Devices/Audio/Channel.h b/Kernel/Devices/Audio/Channel.h
@@ -21,7 +21,7 @@ class AudioChannel final
 
 public:
  static NonnullRefPtr<AudioChannel> must_create(AudioController const&, size_t channel_index);
- virtual ~AudioChannel() override { }
+ virtual ~AudioChannel() override = default;
 
  // ^CharacterDevice
  virtual bool can_read(const OpenFileDescription&, u64) const override;

diff --git a/Kernel/Devices/BlockDevice.cpp b/Kernel/Devices/BlockDevice.cpp
@@ -24,9 +24,7 @@ void AsyncBlockDeviceRequest::start()
  m_block_device.start_request(*this);
 }
 
-BlockDevice::~BlockDevice()
-{
-}
+BlockDevice::~BlockDevice() = default;
 
 bool BlockDevice::read_block(u64 index, UserOrKernelBuffer& buffer)
 {

diff --git a/Kernel/Devices/CharacterDevice.cpp b/Kernel/Devices/CharacterDevice.cpp
@@ -8,8 +8,6 @@
 
 namespace Kernel {
 
-CharacterDevice::~CharacterDevice()
-{
-}
+CharacterDevice::~CharacterDevice() = default;
 
 }
diff --git a/Kernel/Devices/ConsoleDevice.cpp b/Kernel/Devices/ConsoleDevice.cpp
@@ -28,9 +28,7 @@ UNMAP_AFTER_INIT ConsoleDevice::ConsoleDevice()
 {
 }
 
-UNMAP_AFTER_INIT ConsoleDevice::~ConsoleDevice()
-{
-}
+UNMAP_AFTER_INIT ConsoleDevice::~ConsoleDevice() = default;
 
 bool ConsoleDevice::can_read(const Kernel::OpenFileDescription&, u64) const
 {

diff --git a/Kernel/Devices/DeviceControlDevice.cpp b/Kernel/Devices/DeviceControlDevice.cpp
@@ -27,9 +27,7 @@ UNMAP_AFTER_INIT DeviceControlDevice::DeviceControlDevice()
 {
 }
 
-UNMAP_AFTER_INIT DeviceControlDevice::~DeviceControlDevice()
-{
-}
+UNMAP_AFTER_INIT DeviceControlDevice::~DeviceControlDevice() = default;
 
 ErrorOr<size_t> DeviceControlDevice::read(OpenFileDescription&, u64, UserOrKernelBuffer& buffer, size_t size)
 {

diff --git a/Kernel/Devices/FullDevice.cpp b/Kernel/Devices/FullDevice.cpp
@@ -25,9 +25,7 @@ UNMAP_AFTER_INIT FullDevice::FullDevice()
 {
 }
 
-UNMAP_AFTER_INIT FullDevice::~FullDevice()
-{
-}
+UNMAP_AFTER_INIT FullDevice::~FullDevice() = default;
 
 bool FullDevice::can_read(const OpenFileDescription&, u64) const
 {

diff --git a/Kernel/Devices/HID/KeyboardDevice.cpp b/Kernel/Devices/HID/KeyboardDevice.cpp
@@ -276,9 +276,7 @@ UNMAP_AFTER_INIT KeyboardDevice::KeyboardDevice()
 
 // FIXME: UNMAP_AFTER_INIT is fine for now, but for hot-pluggable devices
 // like USB keyboards, we need to remove this
-UNMAP_AFTER_INIT KeyboardDevice::~KeyboardDevice()
-{
-}
+UNMAP_AFTER_INIT KeyboardDevice::~KeyboardDevice() = default;
 
 bool KeyboardDevice::can_read(const OpenFileDescription&, u64) const
 {

diff --git a/Kernel/Devices/HID/MouseDevice.cpp b/Kernel/Devices/HID/MouseDevice.cpp
@@ -14,9 +14,7 @@ MouseDevice::MouseDevice()
 {
 }
 
-MouseDevice::~MouseDevice()
-{
-}
+MouseDevice::~MouseDevice() = default;
 
 bool MouseDevice::can_read(const OpenFileDescription&, u64) const
 {

diff --git a/Kernel/Devices/HID/PS2KeyboardDevice.cpp b/Kernel/Devices/HID/PS2KeyboardDevice.cpp
@@ -116,8 +116,6 @@ UNMAP_AFTER_INIT PS2KeyboardDevice::PS2KeyboardDevice(const I8042Controller& ps2
 
 // FIXME: UNMAP_AFTER_INIT might not be correct, because in practice PS/2 devices
 // are hot pluggable.
-UNMAP_AFTER_INIT PS2KeyboardDevice::~PS2KeyboardDevice()
-{
-}
+UNMAP_AFTER_INIT PS2KeyboardDevice::~PS2KeyboardDevice() = default;
 
 }
diff --git a/Kernel/Devices/HID/PS2MouseDevice.cpp b/Kernel/Devices/HID/PS2MouseDevice.cpp
@@ -26,9 +26,7 @@ UNMAP_AFTER_INIT PS2MouseDevice::PS2MouseDevice(const I8042Controller& ps2_contr
 {
 }
 
-UNMAP_AFTER_INIT PS2MouseDevice::~PS2MouseDevice()
-{
-}
+UNMAP_AFTER_INIT PS2MouseDevice::~PS2MouseDevice() = default;
 
 bool PS2MouseDevice::handle_irq(const RegisterState&)
 {

diff --git a/Kernel/Devices/HID/VMWareMouseDevice.cpp b/Kernel/Devices/HID/VMWareMouseDevice.cpp
@@ -57,8 +57,6 @@ VMWareMouseDevice::VMWareMouseDevice(const I8042Controller& ps2_controller)
  : PS2MouseDevice(ps2_controller)
 {
 }
-VMWareMouseDevice::~VMWareMouseDevice()
-{
-}
+VMWareMouseDevice::~VMWareMouseDevice() = default;
 
 }
diff --git a/Kernel/Devices/MemoryDevice.cpp b/Kernel/Devices/MemoryDevice.cpp
@@ -28,9 +28,7 @@ UNMAP_AFTER_INIT MemoryDevice::MemoryDevice()
 {
 }
 
-UNMAP_AFTER_INIT MemoryDevice::~MemoryDevice()
-{
-}
+UNMAP_AFTER_INIT MemoryDevice::~MemoryDevice() = default;
 
 ErrorOr<size_t> MemoryDevice::read(OpenFileDescription&, u64 offset, UserOrKernelBuffer& buffer, size_t length)
 {

diff --git a/Kernel/Devices/NullDevice.cpp b/Kernel/Devices/NullDevice.cpp
@@ -24,9 +24,7 @@ UNMAP_AFTER_INIT NullDevice::NullDevice()
 {
 }
 
-UNMAP_AFTER_INIT NullDevice::~NullDevice()
-{
-}
+UNMAP_AFTER_INIT NullDevice::~NullDevice() = default;
 
 bool NullDevice::can_read(const OpenFileDescription&, u64) const
 {

diff --git a/Kernel/Devices/RandomDevice.cpp b/Kernel/Devices/RandomDevice.cpp
@@ -24,9 +24,7 @@ UNMAP_AFTER_INIT RandomDevice::RandomDevice()
 {
 }
 
-UNMAP_AFTER_INIT RandomDevice::~RandomDevice()
-{
-}
+UNMAP_AFTER_INIT RandomDevice::~RandomDevice() = default;
 
 bool RandomDevice::can_read(const OpenFileDescription&, u64) const
 {

diff --git a/Kernel/Devices/SerialDevice.cpp b/Kernel/Devices/SerialDevice.cpp
@@ -52,9 +52,7 @@ UNMAP_AFTER_INIT SerialDevice::SerialDevice(IOAddress base_addr, unsigned minor)
  initialize();
 }
 
-UNMAP_AFTER_INIT SerialDevice::~SerialDevice()
-{
-}
+UNMAP_AFTER_INIT SerialDevice::~SerialDevice() = default;
 
 bool SerialDevice::can_read(const OpenFileDescription&, u64) const
 {

diff --git a/Kernel/Devices/ZeroDevice.cpp b/Kernel/Devices/ZeroDevice.cpp
@@ -24,9 +24,7 @@ UNMAP_AFTER_INIT ZeroDevice::ZeroDevice()
 {
 }
 
-UNMAP_AFTER_INIT ZeroDevice::~ZeroDevice()
-{
-}
+UNMAP_AFTER_INIT ZeroDevice::~ZeroDevice() = default;
 
 bool ZeroDevice::can_read(const OpenFileDescription&, u64) const
 {

diff --git a/Kernel/FileSystem/AnonymousFile.cpp b/Kernel/FileSystem/AnonymousFile.cpp
@@ -15,9 +15,7 @@ AnonymousFile::AnonymousFile(NonnullRefPtr<Memory::AnonymousVMObject> vmobject)
 {
 }
 
-AnonymousFile::~AnonymousFile()
-{
-}
+AnonymousFile::~AnonymousFile() = default;
 
 ErrorOr<Memory::Region*> AnonymousFile::mmap(Process& process, OpenFileDescription&, Memory::VirtualRange const& range, u64 offset, int prot, bool shared)
 {

diff --git a/Kernel/FileSystem/BlockBasedFileSystem.cpp b/Kernel/FileSystem/BlockBasedFileSystem.cpp
@@ -114,9 +114,7 @@ BlockBasedFileSystem::BlockBasedFileSystem(OpenFileDescription& file_description
  VERIFY(file_description.file().is_seekable());
 }
 
-BlockBasedFileSystem::~BlockBasedFileSystem()
-{
-}
+BlockBasedFileSystem::~BlockBasedFileSystem() = default;
 
 ErrorOr<void> BlockBasedFileSystem::initialize()
 {

diff --git a/Kernel/FileSystem/Custody.cpp b/Kernel/FileSystem/Custody.cpp
@@ -47,9 +47,7 @@ Custody::Custody(Custody* parent, NonnullOwnPtr<KString> name, Inode& inode, int
 {
 }
 
-Custody::~Custody()
-{
-}
+Custody::~Custody() = default;
 
 ErrorOr<NonnullOwnPtr<KString>> Custody::try_serialize_absolute_path() const
 {

diff --git a/Kernel/FileSystem/DevPtsFS.cpp b/Kernel/FileSystem/DevPtsFS.cpp
@@ -17,13 +17,8 @@ ErrorOr<NonnullRefPtr<DevPtsFS>> DevPtsFS::try_create()
  return adopt_nonnull_ref_or_enomem(new (nothrow) DevPtsFS);
 }
 
-DevPtsFS::DevPtsFS()
-{
-}
-
-DevPtsFS::~DevPtsFS()
-{
-}
+DevPtsFS::DevPtsFS() = default;
+DevPtsFS::~DevPtsFS() = default;
 
 ErrorOr<void> DevPtsFS::initialize()
 {
@@ -81,9 +76,7 @@ DevPtsFSInode::DevPtsFSInode(DevPtsFS& fs, InodeIndex index, SlavePTY* pty)
  m_pty = *pty;
 }
 
-DevPtsFSInode::~DevPtsFSInode()
-{
-}
+DevPtsFSInode::~DevPtsFSInode() = default;
 
 ErrorOr<size_t> DevPtsFSInode::read_bytes(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const
 {

diff --git a/Kernel/FileSystem/DevTmpFS.cpp b/Kernel/FileSystem/DevTmpFS.cpp
@@ -16,9 +16,7 @@ ErrorOr<NonnullRefPtr<DevTmpFS>> DevTmpFS::try_create()
  return adopt_nonnull_ref_or_enomem(new (nothrow) DevTmpFS);
 }
 
-DevTmpFS::DevTmpFS()
-{
-}
+DevTmpFS::DevTmpFS() = default;
 
 size_t DevTmpFS::allocate_inode_index()
 {
@@ -28,9 +26,7 @@ size_t DevTmpFS::allocate_inode_index()
  return 1 + m_next_inode_index.value();
 }
 
-DevTmpFS::~DevTmpFS()
-{
-}
+DevTmpFS::~DevTmpFS() = default;
 
 ErrorOr<void> DevTmpFS::initialize()
 {
@@ -167,9 +163,7 @@ StringView DevTmpFSLinkInode::name() const
  return m_name->view();
 }
 
-DevTmpFSLinkInode::~DevTmpFSLinkInode()
-{
-}
+DevTmpFSLinkInode::~DevTmpFSLinkInode() = default;
 
 DevTmpFSLinkInode::DevTmpFSLinkInode(DevTmpFS& fs, NonnullOwnPtr<KString> name)
  : DevTmpFSInode(fs)
@@ -206,9 +200,7 @@ DevTmpFSDirectoryInode::DevTmpFSDirectoryInode(DevTmpFS& fs, NonnullOwnPtr<KStri
  , m_name(move(name))
 {
 }
-DevTmpFSDirectoryInode::~DevTmpFSDirectoryInode()
-{
-}
+DevTmpFSDirectoryInode::~DevTmpFSDirectoryInode() = default;
 
 ErrorOr<void> DevTmpFSDirectoryInode::traverse_as_directory(Function<ErrorOr<void>(FileSystem::DirectoryEntryView const&)> callback) const
 {
@@ -286,9 +278,7 @@ DevTmpFSRootDirectoryInode::DevTmpFSRootDirectoryInode(DevTmpFS& fs)
 {
  m_mode = 0555;
 }
-DevTmpFSRootDirectoryInode::~DevTmpFSRootDirectoryInode()
-{
-}
+DevTmpFSRootDirectoryInode::~DevTmpFSRootDirectoryInode() = default;
 ErrorOr<void> DevTmpFSRootDirectoryInode::chmod(mode_t)
 {
  return EPERM;
@@ -306,9 +296,7 @@ DevTmpFSDeviceInode::DevTmpFSDeviceInode(DevTmpFS& fs, MajorNumber major_number,
 {
 }
 
-DevTmpFSDeviceInode::~DevTmpFSDeviceInode()
-{
-}
+DevTmpFSDeviceInode::~DevTmpFSDeviceInode() = default;
 
 StringView DevTmpFSDeviceInode::name() const
 {

diff --git a/Kernel/FileSystem/Ext2FileSystem.cpp b/Kernel/FileSystem/Ext2FileSystem.cpp
@@ -59,9 +59,7 @@ Ext2FS::Ext2FS(OpenFileDescription& file_description)
 {
 }
 
-Ext2FS::~Ext2FS()
-{
-}
+Ext2FS::~Ext2FS() = default;
 
 ErrorOr<void> Ext2FS::flush_super_block()
 {