Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics/Screen Recorder: Add gpu-screen-recorder and gpu-screen-recorder #819

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

sonic2kk
Copy link
Contributor

@sonic2kk sonic2kk commented Jun 19, 2024

Adds gpu-screen-recorder and its official frontend gpu-screen-recorder-gtk; a hardware accelerated video recorder for capturing high quality footage in a variety of codecs. It is a commandline tool but the author hosts a GTK frontend that sees equally active development.

As well as screen recording, gpu-screen-recorder also offers a replay buffer feature, capturing the last N number of seconds of footage in a buffer. This is useful for gaming where you may want to have this running so you can effectively capture snippets.

gpu-screen-recorder and gpu-screen-recorder-gtk are FOSS (available git.dec05eba.com, licensed under the terms of the GNU GPLv3 license (gpu-screen-recorder license, gpu-screen-recorder-git license)


NOTE: I was unsure about the naming, as most places including most of the README for the official project refer to it as "gpu-screen-recorder", the only exception I saw was the title for the main repo that calls it "GPU Screen Recorder." However the GTK frontend repo then refers to the main tool as "gpu-screen-recorder." Let me know if you have any preference on naming. 🙂

Summary by Sourcery

This pull request introduces gpu-screen-recorder, a hardware-accelerated CLI screen recording tool, and its official GTK frontend, gpu-screen-recorder-gtk. The README.md file has been updated to list these new tools.

  • New Features:
    • Added gpu-screen-recorder, a CLI tool for hardware-accelerated screen recording and replay buffer functionality.
    • Added gpu-screen-recorder-gtk, the official GTK-based frontend for gpu-screen-recorder.
  • Documentation:
    • Updated README.md to include gpu-screen-recorder and gpu-screen-recorder-gtk in the list of screen recording tools.

Copy link
Contributor

sourcery-ai bot commented Jun 19, 2024

Reviewer's Guide by Sourcery

This pull request adds two new entries to the README.md file: gpu-screen-recorder, a hardware-accelerated CLI screen recorder with a replay buffer feature, and gpu-screen-recorder-gtk, its official GTK-based frontend. These tools are open-source and licensed under the GNU GPLv3.

File-Level Changes

Files Changes
README.md Added entries for gpu-screen-recorder and its GTK frontend gpu-screen-recorder-gtk to the list of screen recording tools.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@sonic2kk sonic2kk changed the title Graphics/Screen Recorder: Add gpu-screen-recorder and gpu-screen-reco… Graphics/Screen Recorder: Add gpu-screen-recorder and gpu-screen-recorder Jun 19, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sonic2kk - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@luong-komorebi luong-komorebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition, thank you @sonic2kk

@luong-komorebi luong-komorebi merged commit c23a6b4 into luong-komorebi:master Jun 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants