Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split example test into feature unit tests. #100

Open
romandev opened this issue Oct 3, 2017 · 1 comment
Open

Split example test into feature unit tests. #100

romandev opened this issue Oct 3, 2017 · 1 comment

Comments

@romandev
Copy link
Member

romandev commented Oct 3, 2017

To implement POC ASAP, we didn't consider project structure much, especially, testing part. As the number of contributors grows, we need to write more tests and make the structure robust.

@hwanseung
Copy link
Contributor

i agree. for now testing code and example code are mixed.
so we should split test code from example code.
and that test code should not have coupling with example code.

romandev added a commit that referenced this issue Oct 7, 2017
This patch is adding a new test IDL interface to test/ directory.
After this patch, we can build a multiple IDL files and use them.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
This patch is adding a new test IDL interface to test/ directory.
After this patch, we can build a multiple IDL files and use them.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
Rewrite examples/ tests using jest.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
Rewrite examples/ tests using jest.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
romandev added a commit that referenced this issue Oct 8, 2017
This patch also changes getCalledConstructorInfo() to static method and
rename it with getLastCallInfo() and then use it use generally.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
This patch also changes getCalledConstructorInfo() to static method and
rename it with getLastCallInfo() and then use it use generally.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
romandev added a commit that referenced this issue Oct 8, 2017
romandev added a commit that referenced this issue Oct 8, 2017
Write a test for Basic Types such as boolean, short, double, and string.
Not include long type testing in this patch because it has some problem.
We should fix the issue in follow-up patch.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
Write a test for Basic Types such as boolean, short, double, and string.
Not include long type testing in this patch because it has some problem.
We should fix the issue in follow-up patch.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
Write a test for Basic Types such as boolean, short, double, and string.
Not include long type testing in this patch because it has some problem.
We should fix the issue in follow-up patch.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
It's better to inform details.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
It's better to inform details.

ISSUE=#99,#100
romandev pushed a commit that referenced this issue Oct 8, 2017
Write a test for enum type using jest.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 18, 2017
This patch is adding a new test IDL interface to test/ directory.
After this patch, we can build a multiple IDL files and use them.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 18, 2017
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 18, 2017
Rewrite examples/ tests using jest.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 18, 2017
This patch also changes getCalledConstructorInfo() to static method and
rename it with getLastCallInfo() and then use it use generally.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 18, 2017