💄 Add form validation feedback

[lukevella]

Summary by CodeRabbit

• New Features
  • Enhanced the Discussion component to display error indications in the NameInput field when form errors are present.
• Refactor
  • Updated the NameInput component to use a more efficient class naming utility, improving error state visual feedback.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 26, 2024 5:57am
landing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 26, 2024 5:57am

[coderabbitai]

Walkthrough

The update enhances the user interface by improving error feedback in a form component. Specifically, it modifies how the NameInput component within a Discussion form displays errors. This involves not only a change in the props passed to NameInput but also a switch in utility for styling based on error presence, shifting from clsx to cn for conditional class application.

Changes

Files	Change Summary
.../discussion/discussion.tsx	Updated NameInput rendering to include an error prop based on form state errors.
.../name-input.tsx	Replaced clsx with cn from "@rallly/ui"; Added error prop handling for conditional styling.

🐇✨
Changes afoot, oh what a sight,
Error rings red, where once was none,
cn and error, now join the fun,
A form now bright, in the user's delight. 🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 63c6c4f and 154be22.

Files selected for processing (2)

• apps/web/src/components/discussion/discussion.tsx (1 hunks)
• apps/web/src/components/name-input.tsx (3 hunks)

Additional comments: 4

apps/web/src/components/name-input.tsx (3)

• 1-1: The switch from clsx to cn for conditional class application is noted. Ensure that cn provides the same or improved functionality compared to clsx for this use case.
• 14-14: The addition of the error prop to NameInputProps is appropriate for enabling dynamic styling based on validation state. This aligns with the PR's objective of enhancing form validation feedback.
• 32-36: The conditional application of the "ring-destructive ring-1" class based on the error prop using cn is correctly implemented. This effectively provides visual feedback for validation errors, enhancing user experience.

apps/web/src/components/discussion/discussion.tsx (1)

• 169-171: The modification to include an error prop in the NameInput component based on form validation errors is correctly implemented. This change effectively utilizes the NameInput component's new capability to provide visual feedback on input validation, aligning with the PR's objectives.