-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔓 Add config to secure instance from unauth users #559
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e518c80
to
7547abc
Compare
7547abc
to
f37acf7
Compare
Hi, this doesn't work in my installation. Do you have an idea? |
Same, I have the following my
But it still requires users to create an account, see https://schedule.uniteddiversity.coop |
This is config for v2. In v3 it was changed so that auth is required by default for poll creators and there's no option to disable it for self-hosted instances. Auth is not required for users participating in a poll. |
Ah, OK, many thanks for clarifying that @lukevella It's a bit of a shame though as IMHO it's a nice/ better UX how it is on https://app.rallly.co/ where you can jump straight into https://app.rallly.co/new (which is presumably why you've got it set-up like that), and it'd be nice if it were possible to replicate that on self-hosted instances too. Is it worth adding a feature request to that effect, or do you simply have no plans of making that possible? Thanks again. |
@jdaviescoates If you're looking for convenience, why not use the managed service? Having multiple open instances of Rallly can harm the project as some users might not even realize they are not using the hosted version and this leads to all sorts of problems which was the main motivation for this move. |
Ah, ok - thanks for the info. |
This: https://support.rallly.co/self-hosting/pricing#suggested-price ? |
Just because I prefer to self-host things on my own domains if at all possible 🙂
I'm unclear on what harm and problems it could cause, but fair enough I guess 🙂 I'm probably missing something obvious. (Although TBH, given how generally confused people often get about simple tech stuff, I think even when people are using self-hosted instances with auth lots of people might not realise they aren't using the hosted version, if they even know a hosted version exists - of course at present the vast majority of people have never even heard of Rallly hosted or otherwise, ) |
So, to clarify, the reason people want to run an open instance is not because they want to allow anyone to use it, but it's because they don't want to spend time logging in? Doesn't it make more sense to work on making logging in easier then? |
I'm confused, who said that? As you know given you made it(!) it's already possible to run an open instance where anyone can create an account. But some people would like to run an open instance where you can create polls without having to first create an account (basically exactly as you can on https://app.rallly.co/new right now) I'd guess they'd want to do this for exactly the same reason that you yourself want people to be able to do it on https://app.rallly.co/new - which I'm presuming is because it improves the UX by reducing friction and making it easier for people to create polls? 🤷♂️
Well, that wasn't the motivation, but now you mention it, whilst it's already pretty easy, OIDC would make it even easier for people within our orgs to login! 🙂 |
I'm just trying to understand what you want. Do you want to allow anyone to use your instance? In that case, an open-instance is the solution, but it would help to understand why you want this. If you find logging in painful, running an open-instance is a pretty extreme way to solve this problem. My time would be better invested providing alternative login solutions like OIDC or password login which benefits everyone not just self-hosters. The managed version is open to make it easier to onboard people. UX is improved only in the sense that the barrier for entry is reduced but you get less features as a guest and this will become more obvious as more features are added. |
Yes, I'd like anyone to be able to use my instance. I want to do this just because I like to offer nice useful tools to other people, and it makes our co-op look good and nice to be able to provide such useful services on our own domains.
I don't find logging in painful. But OIDC would be great.
Exactly, the barrier for entry is reduced and it's easier to onboard people if they can just jump in and use the app without immediately having to create an account first by entering their email. Totally fine/ good that they would then have to enter their email to access admin/ others features. People are used to that with Doodle etc. |
Many self-hosters ask to be able to secure their instance to prevent unauthorized users from creating polls on their instance. This update addresses this issue by adding the following configuration properties:
AUTH_REQUIRED
false
true
to require authentication for creating new polls and accessing admin pagesALLOWED_EMAILS
""
If not set, all emails are allowed.
Wildcard characters are supported.
Example:
"[email protected], *@example.com, *@*.example.com"
DISABLE_LANDING_PAGE
false
true
to take users straight to the app