Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Remove legacy start column #1113

Merged
merged 4 commits into from
May 18, 2024
Merged

♻️ Remove legacy start column #1113

merged 4 commits into from
May 18, 2024

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented May 18, 2024

Summary by CodeRabbit

  • New Features

    • Dynamic time zone display formatting based on poll's time zone.
  • Bug Fixes

    • Renamed start to startTime in various components for consistency.
  • Chores

    • Removed deprecated start column from the database schema.
    • Updated API response structure to reflect changes in poll options.
  • Refactor

    • Removed useCurrentPollOptions function from the current event context.

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 9:30am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
landing ⬜️ Ignored (Inspect) Visit Preview May 18, 2024 9:30am

Copy link
Contributor

coderabbitai bot commented May 18, 2024

Warning

Rate Limit Exceeded

@lukevella has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 36 minutes and 58 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between a82f6ab and 46da4fb.

Walkthrough

This update primarily focuses on renaming the start property to startTime across various components and modules, enhancing time zone formatting, and removing deprecated functionalities. Key changes include adjustments to the FinalizePollForm and FinalTime components, updates to the GetPollApiResponse type, and modifications in the Prisma schema and database migrations to reflect the new startTime property.

Changes

Files Change Summary
apps/web/src/components/poll/manage-poll/finalize-poll-dialog.tsx Renamed start to startTime when passing to DateIcon.
apps/web/src/components/scheduled-event.tsx Updated time zone display format based on poll.timeZone condition.
apps/web/src/contexts/current-event.ts Removed useCurrentPollOptions function.
apps/web/src/utils/trpc/types.ts Modified GetPollApiResponse type, removing start and including startTime in options.
packages/backend/trpc/routers/polls.ts Removed options import and related configurations, updated start to startTime.
.../prisma/migrations/20240317095541_remove_legacy_start_column/... Dropped start column from options table in SQL script.
packages/database/prisma/schema.prisma Removed start field, added startTime field in Option model.

🐰🌸
A change in time, a shift so slight,
From start to startTime, now feels right.
Polls and options, all aligned,
In code and schema, redefined.
The rabbit hops, with joy and cheer,
For cleaner code, we hold dear.
🌟✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 66d5a84 and a82f6ab.
Files selected for processing (7)
  • apps/web/src/components/poll/manage-poll/finalize-poll-dialog.tsx (1 hunks)
  • apps/web/src/components/scheduled-event.tsx (1 hunks)
  • apps/web/src/contexts/current-event.ts (1 hunks)
  • apps/web/src/utils/trpc/types.ts (1 hunks)
  • packages/backend/trpc/routers/polls.ts (9 hunks)
  • packages/database/prisma/migrations/20240317095541_remove_legacy_start_column/migration.sql (1 hunks)
  • packages/database/prisma/schema.prisma (1 hunks)
Files skipped from review due to trivial changes (3)
  • apps/web/src/contexts/current-event.ts
  • apps/web/src/utils/trpc/types.ts
  • packages/database/prisma/migrations/20240317095541_remove_legacy_start_column/migration.sql
Additional comments not posted (2)
packages/database/prisma/schema.prisma (1)

Line range hint 33-33: Confirm removal of start field and addition of startTime.

The changes correctly reflect the migration from start to startTime in the Option model.

packages/backend/trpc/routers/polls.ts (1)

380-380: Ensure the orderBy clause uses startTime.

The change to use startTime in the orderBy clause of the list query is correctly implemented.

@lukevella lukevella merged commit 533e347 into main May 18, 2024
5 checks passed
@lukevella lukevella deleted the remove-legacy-start branch May 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant