Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Show duration #1098

Merged
merged 1 commit into from
May 16, 2024
Merged

✨ Show duration #1098

merged 1 commit into from
May 16, 2024

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented May 16, 2024

Show duration in poll option

CleanShot 2024-05-16 at 12 16 44@2x

Summary by CodeRabbit

  • New Features

    • Added icons and duration display to mobile poll time slots for enhanced visual clarity.
  • Style

    • Improved layout and styling of poll headers for a cleaner and more intuitive user experience.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:24am
landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:24am

Copy link
Contributor

coderabbitai bot commented May 16, 2024

Walkthrough

The changes primarily focus on enhancing the layout and styling of poll-related components in both desktop and mobile views. Adjustments include refining the display of time ranges, updating the structure of tooltips, and incorporating new icons and props to improve user interface and experience.

Changes

File Path Change Summary
apps/web/src/components/poll/desktop-poll/poll-header.tsx Restructured TimeRange and PollHeader components for better layout and styling; removed Icon import.
apps/web/src/components/poll/mobile-poll/time-slot-option.tsx Added ClockIcon import, duration prop, and rendering of these elements in the component.

🐇✨ In the code where time does play,
Icons dance and tooltips sway.
With new props and styles so bright,
Polls now gleam in users' sight.
A rabbit's joy, a coder's cheer,
For changes made, we all revere!
⏰🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 871c083 and 098c39a.
Files selected for processing (2)
  • apps/web/src/components/poll/desktop-poll/poll-header.tsx (3 hunks)
  • apps/web/src/components/poll/mobile-poll/time-slot-option.tsx (2 hunks)
Additional comments not posted (6)
apps/web/src/components/poll/mobile-poll/time-slot-option.tsx (3)

1-1: Import statement for ClockIcon looks good.


Line range hint 7-9: Addition of duration prop to TimeSlotOptionProps looks good.


15-25: Changes to the TimeSlotOption component look good.

apps/web/src/components/poll/desktop-poll/poll-header.tsx (3)

Line range hint 6-6: Import statement for ClockIcon looks good.


22-36: Changes to the TimeRange component look good.


153-154: Changes to the PollHeader component look good.

@lukevella lukevella enabled auto-merge (squash) May 16, 2024 04:22
@lukevella lukevella merged commit dee3e1b into main May 16, 2024
5 checks passed
@lukevella lukevella deleted the time-option-duration branch June 10, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant