-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to customize the sender name for mails #1023
Conversation
@BelOrta-TDP is attempting to deploy a commit to the rallly Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update introduces a new configuration option, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
turbo.json
is excluded by:!**/*.json
Files selected for processing (2)
- apps/docs/self-hosting/configuration-options.mdx (1 hunks)
- apps/web/src/utils/emails.ts (1 hunks)
Additional comments: 1
apps/docs/self-hosting/configuration-options.mdx (1)
- 44-47: The documentation for
NOREPLY_EMAIL_NAME
is clear and accurately reflects the implementation. It specifies the default behavior when the variable is not set, which is consistent with the code changes inemails.ts
.
name: | ||
(process.env.NOREPLY_EMAIL_NAME as string) || | ||
"Rallly", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the cast to string
for process.env.NOREPLY_EMAIL_NAME
is necessary. If process.env.NOREPLY_EMAIL_NAME
is undefined or not set, the fallback value "Rallly" will be used, which is correct. However, consider checking for empty string values as well, as an empty string is truthy when cast to string
, potentially leading to an unintended sender name.
- (process.env.NOREPLY_EMAIL_NAME as string) || "Rallly",
+ process.env.NOREPLY_EMAIL_NAME?.trim() || "Rallly",
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
name: | |
(process.env.NOREPLY_EMAIL_NAME as string) || | |
"Rallly", | |
name: | |
process.env.NOREPLY_EMAIL_NAME?.trim() || "Rallly", |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for you contribution. Will be available in the next release 👌 |
Description
Fix for issue #994
Checklist
Please check off all the following items with an "x" in the boxes before requesting a review.
Summary by CodeRabbit