-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add plain text version for each email #1005
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Warning Rate Limit Exceeded@lukevella has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 12 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/emails/src/send-email.tsx (2 hunks)
Additional comments: 2
packages/emails/src/send-email.tsx (2)
- 90-93: The use of
Promise.all
to concurrently render HTML and plain text versions of the email is efficient. However, ensure that therenderAsync
function is designed to handle the same component instance being passed to it concurrently without any side effects or race conditions.- 102-102: Including the plain text version of the email (
text
) alongside the HTML version (html
) in thesendEmail
function call is a good practice for accessibility and compatibility. This ensures that recipients can read the email content regardless of their email client's capabilities.
Summary by CodeRabbit