Extraction improvements (blogspot fix) #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that extraction of blogspot articles was really poor.
Looking at the HTML for blogspot I noticed that these classes are used but they aren't given a high weight by
readability.Adding these regexes fixed it for me.
Let me know if you have any concerns. Blogspot is pretty prevalent and it would be great to see readability handle these pages well.
Example page: https://mechanical-sympathy.blogspot.ca/2012/08/memory-access-patterns-are-important.html
Also fixed a failing test. Seems that requesting the white-house website can yield inconsistent results. Downloaded the html and added it as a fixture.