Bump request package version #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luin @haroldtreen sorry for bothering but can we merge it? CI is passing, the change is simple, should be pretty straightforward to merge ;) |
|
Minor version updates should be okay. I can't update the Sorry for the delay - thanks for noticing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! The pinned version of request (2.40) is really ancient and has some issues. Personally, I ran into stack overflows, not to mention all the security issues.
Tests are passing and I think this one is safe to merge.
We should probably go over other dependencies as well, but I guess updating stuff like jsdom is more tricky :)