Syntax changes and model update changes #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
commented
Sep 10, 2023
| {% for incident in officer.incidents | sort(attribute='date') | reverse %} | ||
| {% for incident in officer.incidents %} |
There was a problem hiding this comment.
This is now covered in the view.
michplunkett
commented
Sep 10, 2023
Comment on lines
-226
to
-227
| if "created_by" in data: | ||
| link.created_by = parse_int(data.get("created_by")) |
There was a problem hiding this comment.
The created_by field shouldn't be updated.
michplunkett
requested review from
sea-kelp,
abandoned-prototype and
b-meson
sea-kelp
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Should this also be replaced with a constant?
https://github.com/lucyparsons/OpenOversight/pull/1056/files#diff-0ea02af7be8529b5f1eb21efd1af13f1d633060c50ee2529a1064ddba1616c93L76-L80
|
@sea-kelp, at the very least it should be an f-string. We can change that on the next code change. |
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
This was referenced Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
A lot of small syntax changes along with adding missing field inclusions.
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.