5.0.0 #3
Merged
5.0.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ 147f569-PortMidi.Readernow passes abuffer_sizeto the underlying nif, saving MIDI messages from being lost. Thisbuffer_sizeis set to 256 by default, and can be configured at application level:config :portmidi, buffer_size: 1024@ ed9e3bb-PortMidi.Readernow emits messages as lists, no more as simple tuples. Sometimes there could be only one message, but a list is always returned. The tuples have also changed structure, to include timestamps, that were previously ignored:[{{status, note1, note2}, timestamp}, ...]@ d202f7a-PortMidi.Writernow accepts good old message tuples ({status, note1, note2}), event tuples, with timestamp ({{status, note1, note2}, timestamp}) or lists of event tuples ([{{status, note1, note2}, timestamp}, ...]). This is the preferred way for high throughput, and can be safely used as a pipe from an input device.