Improve error handling when updating the trigger histories #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
approved these changes
May 4, 2021
|
@tmccombs I see the |
ribsalad
commented
May 4, 2021
| finish = Values(finish), | ||
| misfire = Values(misfire), | ||
| fire_instance_id = Values(fire_instance_id) | ||
| """.stripMargin, |
There was a problem hiding this comment.
Oh this is the problem, my IDE is set up to add the trailing commas with the formatter when I ctrl+s.
…e on duplicate keys. In the case of a mis fired trigger, inserting into the DB shouldn't cause an exception. Instead, we should update the existing entry to match the misfired trigger matching the primary key. This can happen many times until the trigger stops misfiring.
14a9feb
to
4b124a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a trigger misfires, insert it into the trigger histories and update on duplicate keys.
In the case of a mis fired trigger, inserting into the DB shouldn't cause an exception. Instead, we should update the existing entry to match the misfired trigger matching the primary key. This can happen many times until the trigger stops misfiring.