-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added philippine-peso
icon
#2231
Open
kasutu
wants to merge
25
commits into
lucide-icons:main
Choose a base branch
from
kasutu:studio/philippine-peso
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added or changed iconsIcons as codeWorks for: const PhilippinePesoIcon = createLucideIcon('PhilippinePeso', [
["path",{"d":"M20 11H4"}],
["path",{"d":"M20 7H4"}],
["path",{"d":"M7 21V4a1 1 0 0 1 1-1h4a1 1 0 0 1 0 12H7"}]
]) |
thank you @jguddas |
jguddas
requested changes
Jun 19, 2024
added author
reordered author
jguddas
reviewed
Jun 19, 2024
Co-authored-by: Jakob Guddas <[email protected]>
You need to not forget about the 2px gap rule. |
jguddas
reviewed
Jun 24, 2024
Co-authored-by: Jakob Guddas <[email protected]>
jguddas
approved these changes
Jun 26, 2024
How cleverly this icon made! I am quite surprised about the result. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2230
What is the purpose of this pull request?
Description
Icon use case
Represents the Philippine currency.
Icon Design Checklist
Concept
Author, credits & license
russian-ruble
,dollar-sign
Naming
icons/philippine-peso.json
.Design
Before Submitting