Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): update drill icon #1919

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Feb 24, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Hand optimized icon

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Feb 24, 2024
Copy link

github-actions bot commented Feb 24, 2024

Added or changed icons

icons/drill.svg

Preview cohesion icons/message-square-more.svg
icons/drill.svg
icons/arrow-left-right.svg
Preview stroke widths icons/drill.svg
icons/drill.svg
icons/drill.svg
DPI Preview (24px) icons/drill.svg
Icon X-rays icons/drill.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const DrillIcon = createLucideIcon('Drill', [
  ["path",{"d":"M10 18a1 1 0 0 1 1 1v2a1 1 0 0 1-1 1H5a3 3 0 0 1-3-3 1 1 0 0 1 1-1z"}],
  ["path",{"d":"M13 10H4a2 2 0 0 1-2-2V4a2 2 0 0 1 2-2h9a1 1 0 0 1 1 1v6a1 1 0 0 1-1 1l-.81 3.242a1 1 0 0 1-.97.758H8"}],
  ["path",{"d":"M14 4h3a1 1 0 0 1 1 1v2a1 1 0 0 1-1 1h-3"}],
  ["path",{"d":"M18 6h4"}],
  ["path",{"d":"m5 10-2 8"}],
  ["path",{"d":"m7 18 2-8"}]
])

@karsa-mistmere
Copy link
Member

It would be nice to also fix the gap issue somehow, some ideas:
image

icons/drill.svg Outdated Show resolved Hide resolved
@karsa-mistmere karsa-mistmere changed the title Update drill icon fix(icons): update drill icon Feb 25, 2024
@karsa-mistmere
Copy link
Member

It would be nice to also fix the gap issue somehow, some ideas: image

Pinging this.

@karsa-mistmere
Copy link
Member

It would be nice to also fix the gap issue somehow, some ideas: image

Pinging this.

@ericfennis ericfennis requested a review from karsa-mistmere 1 minute ago

@jguddas, @ericfennis: Pinging this again.

@jguddas
Copy link
Member Author

jguddas commented Aug 2, 2024

No clue what I need to do here.

@karsa-mistmere
Copy link
Member

No clue what I need to do here.

The trigger doesn't have the necessary 2px gap (and it's also a bit too off-grid).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants