Docker Image Addition #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-medeiros
requested changes
Jan 24, 2024
There was a problem hiding this comment.
@kauevestena Hey, really appreciate you taking the time to solve this recurring issue. Bet lots of people will use it well.
Wrote a few suggestions that we should fix before merging!
Sim, sou brasileiro :)
Co-authored-by: Luca Medeiros <[email protected]>
|
I think that's it for now! And as we say: é nós que avua meu caro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and approach used
Well, I saw many issues on dependencies, that are a common shared hell, and thank you, universe, there's Docker.
Fixes #39 #38 #30 #26 #20 #13 and probably others. Well at least, provided that user got Docker Engine Installed =D
Checklist before requesting a review
Also,
@luca-medeiros by your name I will ask: Tu é brasileiro?
Kindest regards,
Kauê