Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should pass device in case of cpu #3

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

rballachay
Copy link
Contributor

@rballachay rballachay commented Apr 14, 2023

Default of grounding DINO is cuda, if cpu isn't passed, fails to run on cpu

Describe your changes and approach used

Fixes #ISSUE-NUMBER

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have performed linting on my code.
  • I have linked the related issue.
  • The code is documented accordingly.
  • If it is a core feature, I have added thorough tests.

Default of grounding DINO is cuda, if cpu isn't passed, fails to run
Copy link
Owner

@luca-medeiros luca-medeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! thanks

@luca-medeiros luca-medeiros merged commit 83c6eaf into luca-medeiros:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants